New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-mbedtls-multi] Fix typo in the printf (no functional change) #8482

Merged
merged 1 commit into from Oct 22, 2018

Conversation

Projects
None yet
4 participants
@adustm
Member

adustm commented Oct 19, 2018

Description

testing mbedtls-multi test with verbose option is resulting to OK test, but the display shows differences between awaited result and obtained result.
This is in fact a typo in the printf line showing awaited result.
This PR fixes this.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ x ] Test update
[ ] Breaking change

How to reproduce

mbed test -n tests-mbedtls-multi -v

output is :

[1539875137.56][CONN][RXD] received result ctx1 : 248D6A61D20638B8E5C026930C3E6039A33CE45964FF2167F6ECEDD419DB06C1
[1539875137.64][CONN][RXD] awaited result       : 248D6A61D20638B8E5C026930C3E6039A33CE45964FF216F6ECEDD19DB06C1
...
[1539875138.13][CONN][RXD] >>> 'Crypto: sha256_multi': 1 passed, 0 failed
...
mbedgt: test suite 'tests-mbedtls-multi' ............................................................. OK in 16.22 sec
        test case: 'Crypto: sha256_multi' ............................................................ OK in 0.82 sec
        test case: 'Crypto: sha256_split' ............................................................ OK in 0.29 sec

We can see a difference at the end of awaited result compared to received result, but the test is OK
(and it is really ok, I've checked that)

With this PR, the display is now fixed and the awaited result is the correct one.

[1539875137.56][CONN][RXD] received result ctx1 : 248D6A61D20638B8E5C026930C3E6039A33CE45964FF2167F6ECEDD419DB06C1
[1539875137.64][CONN][RXD] awaited result       : 248D6A61D20638B8E5C026930C3E6039A33CE45964FF2167F6ECEDD419DB06C1
@cmonr

cmonr approved these changes Oct 19, 2018

Jeez, that single character diff must've been a pain to find

@cmonr cmonr added needs: CI and removed needs: review labels Oct 19, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 21, 2018

Build : SUCCESS

Build number : 3423
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8482/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 22, 2018

@cmonr cmonr merged commit b09a843 into ARMmbed:master Oct 22, 2018

13 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 672 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10365 cycles (+92 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment