Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributing: simplify it via a link to our docs #8549

Merged
merged 2 commits into from
Oct 27, 2018
Merged

contributing: simplify it via a link to our docs #8549

merged 2 commits into from
Oct 27, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Oct 25, 2018

Simplify the document. More information is provided on our documentation portal, link it there

There was lot of duplication and as you can read in the diff, outdated information.

Description

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
contributing: update the text
d55bbf6 
Simplify the document. More information is provided on our documentation portal, link it here
cmonr
cmonr approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@0xc0170 0xc0170 changed the title contributing: update the text contributing: simplify it via a link to our docs Oct 25, 2018
Edit CONTRIBUTING.md
c3776a0 
Edit file, mostly for minor comma nits.
AnotherButler
AnotherButler approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@cmonr cmonr mentioned this pull request Oct 26, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Oct 26, 2018

Note: This PR is now a part of a rollup PR (#8552).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

@cmonr cmonr merged commit c3776a0 into ARMmbed:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

@bulislaw bulislaw Awaiting requested review from bulislaw

@sg- sg- Awaiting requested review from sg-

@melwee01 melwee01 Awaiting requested review from melwee01

Assignees
No one assigned
Labels
release-version: 5.10.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xc0170 @cmonr @AnotherButler