New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warning about initializing and variable order #8640

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@KariHaapalehto
Contributor

KariHaapalehto commented Nov 5, 2018

Description

Change order of variables _blocking and _previous_connection_status at initialization to fix compile warnings

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Nov 5, 2018

@artokin FYI

@0xc0170

0xc0170 approved these changes Nov 5, 2018

@0xc0170 0xc0170 added the needs: CI label Nov 6, 2018

@cmonr

cmonr approved these changes Nov 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 7, 2018

Note: This PR is now a part of a rollup PR (#8663).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit c7afb91 into ARMmbed:master Nov 7, 2018

11 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10104 cycles (+177 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Nov 7, 2018

@cmonr cmonr removed the rollup PR label Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment