Skip to content

Conversation

mtomczykmobica
Copy link

@mtomczykmobica mtomczykmobica commented Nov 12, 2018

Description

All tests should leave wifi connection in disconnected state. When test finish with connection state connect, may causing problems with thé next tests.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2018

Description

Please describe your changes and also pull request type

@mtomczykmobica
Copy link
Author

mtomczykmobica commented Nov 12, 2018

Comment added and pull request type set.

@0xc0170 0xc0170 requested a review from a team November 12, 2018 12:36
@adbridge
Copy link
Contributor

/morph build

@jeromecoutant
Copy link
Collaborator

Please describe your changes and also pull request type

And add the github ticket number you are correcting...
Thx

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3623
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8712/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit 29b7c50 into ARMmbed:master Nov 15, 2018
error_connect = wifi->connect();
error_disconnect = wifi->disconnect();
TEST_ASSERT(error_connect == NSAPI_ERROR_NO_SSID || error_connect == NSAPI_ERROR_PARAMETER);
TEST_ASSERT(error_disconnect == NSAPI_ERROR_NO_CONNECTION);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Back to this patch...
Why the disconnect function has to return NSAPI_ERROR_NO_CONNECTION, and not NSAPI_ERROR_OK ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case, there is no connection at all when the disconnect is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants