-
Notifications
You must be signed in to change notification settings - Fork 3k
ONME-3852 Check that test cases disconnect at the end #8712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please describe your changes and also pull request type |
Comment added and pull request type set. |
/morph build |
And add the github ticket number you are correcting... |
Build : SUCCESSBuild number : 3623 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3231 |
Test : FAILUREBuild number : 3407 |
Note: This PR is now a part of a rollup PR (#8753). In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR. No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Please ignore. I derped. |
error_connect = wifi->connect(); | ||
error_disconnect = wifi->disconnect(); | ||
TEST_ASSERT(error_connect == NSAPI_ERROR_NO_SSID || error_connect == NSAPI_ERROR_PARAMETER); | ||
TEST_ASSERT(error_disconnect == NSAPI_ERROR_NO_CONNECTION); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Back to this patch...
Why the disconnect function has to return NSAPI_ERROR_NO_CONNECTION, and not NSAPI_ERROR_OK ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular case, there is no connection at all when the disconnect is called.
Description
All tests should leave wifi connection in disconnected state. When test finish with connection state connect, may causing problems with thé next tests.
Pull request type