New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWANTimer UT fixed #8727

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
6 participants
@AnttiKauppila
Contributor

AnttiKauppila commented Nov 13, 2018

Description

LoRaWAN_Timer unittest was segfaulting, this is fixed now

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change
@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Nov 13, 2018

@TeemuKultala please review

@cmonr

Will LoRaWAN unit tess no longer have debug statements? Or did it never have them to begin with?

@cmonr cmonr added the needs: review label Nov 13, 2018

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Nov 14, 2018

The change is only for LoRaWANTimer class, not the whole LoRaWAN test set

@cmonr

cmonr approved these changes Nov 14, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Nov 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3627
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8727/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 15, 2018

Export nodes got stuck.

Will relaunch when able.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit 0777771 into ARMmbed:master Nov 15, 2018

15 of 17 checks passed

ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
ci-morph-build build completed
Details
ci-morph-mbed2-build build completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 49 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9212 cycles (-1026 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@AnttiKauppila AnttiKauppila deleted the AnttiKauppila:lora_ut_fix branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment