Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance test errors fixed #8735

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Conversation

AnttiKauppila
Copy link

Description

While running pre-certification test for LoRaWAN stack few issues were found. Those are fixed in this PR

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@AnttiKauppila
Copy link
Author

@kivaisan @hasnainvirk Please review

@0xc0170 0xc0170 requested a review from a team November 14, 2018 08:25
Copy link
Contributor

@hasnainvirk hasnainvirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@adbridge adbridge requested a review from a team November 14, 2018 14:45
@cmonr
Copy link
Contributor

cmonr commented Nov 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3630
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8735/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Well, on the plus side, the number of subjobs that failed the Export CI is the lowest of the night...

Will restart when able.

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

NRF52 rtc issue.
Will restart when able.

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Info: This PR has now been bundled into a rollup PR (#8760).

The CI failures that this PR saw do not appear to be the fault of the PR. To save time in retesting this PR, along with other PRs that experienced similar issues, it has been bundled into a rollup PR.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 16, 2018

Info: This PR has been re-bundled into a new rollup PR (#8763).

The previous rollup found an issue with a bundled PR after new devices were added into master. The PR needing work has been removed.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit cf53494 into ARMmbed:master Nov 16, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 16, 2018
@AnttiKauppila AnttiKauppila deleted the Lora_compliance branch November 16, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants