Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: fix coding style for remaining 2 files #8820

Merged
merged 2 commits into from
Nov 24, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 20, 2018

Description

While updating travis script, there landed 2 files that needs fixing the coding style. This PR is to address this. I'll update PR with these files, first need to check if I found them locally, so running travis here with debug msg added.

Update: files located and fixed, ready for review

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 changed the title travis: test to see what files needs fixing travis: fix coding style for remaining 2 files Nov 20, 2018
Missing $ for after_success, same fix as previously done for PR code changes
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 20, 2018

travis-ci/astyle — Passed, 0 files (-2 files)

Job done 💯 🎉

Ready for review

@0xc0170 0xc0170 requested a review from a team November 20, 2018 14:57
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 22, 2018

Info: This PR has been re-bundled into a new rollup PR (#8838 ).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit c1d00df into ARMmbed:master Nov 24, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 24, 2018
@cmonr cmonr removed the rollup PR label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants