-
Notifications
You must be signed in to change notification settings - Fork 3k
Nuvoton: Support DAC HAL #8828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuvoton: Support DAC HAL #8828
Conversation
Test reports of ci-test-shield/analog-out test on NANO130/M453 targets are listed below. M487/M2351 are not listed because their DAC pinout collide with USB VCOM Tx/Rx and cannot run this test. They are tested separately.
|
|
||
const struct nu_modinit_s *modinit = get_modinit(obj->dac, dac_modinit_tab); | ||
MBED_ASSERT(modinit != NULL); | ||
MBED_ASSERT(modinit->modname == obj->dac); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_modinit(...)
can't return modinit
object with modname != obj->dac
.
So, MBED_ASSERT(modinit->modname == obj->dac)
is redundancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyliangtw This is to check the flow PinMap_DAC
/dac_modinit_tab
/get_modinit
is bug-less, like error in any of them, in development time. Anyway, MBED_ASSERT
is removed in release build.
@@ -0,0 +1,198 @@ | |||
/* mbed Microcontroller Library | |||
* Copyright (c) 2015-2016 Nuvoton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the year (2018 for this new file) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add SPDX identifier please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me, just fixing the license headers
1. Fix copyright year 2. Add SPDX
CI started. |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
This PR adds support for DAC (analog-out) HAL on Nuvoton tagets.
Support targets
Pull request type