Skip to content

Conversation

anttiylitokola
Copy link
Contributor

Description

EMPTY response should not be stored to blockwise list.
An Empty message only contains the 4-byte header so it does not require any blockwise operations.
This will fix unneseccary message sending timeouts which leads mbed cloud client to do unnecessary
reconnections which increases the network traffic.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

EMPTY response should not be stored to blockwise list.
An Empty message only contains the 4-byte header so it does not require any blockwise operations.
This will fix unneseccary message sending timeouts which leads mbed cloud client to do unnecessary
reconnections which increases the network traffic.
@anttiylitokola
Copy link
Contributor Author

@teetak01, please review

Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

CI restarted, was aborted due to internal flow issue

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit c59aa99 into ARMmbed:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants