Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add reviewers to the PR template #9151

Merged
merged 2 commits into from
Dec 20, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Dec 19, 2018

Use @mention to request specific reviewers.

Description

Add new section to our Github PR template file. Optional Reviewers

This section should be used to request reviewers . It would be manual currently, automatic addition to Github reviewers will come.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-maintainers @AnotherButler

Use @mention to request specific reviewers.
@ciarmcom ciarmcom requested a review from a team December 19, 2018 12:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 19, 2018

@kjbracey-arm @cmonr @NirSonnenschein at least one more +1 and this will be ready for CI

Fix nit for precise language
@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

CI started

@0xc0170 0xc0170 merged commit c7a5ef5 into ARMmbed:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants