Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform TT_M4G9 #9224

Merged
merged 9 commits into from Feb 25, 2019
Merged

Add platform TT_M4G9 #9224

merged 9 commits into from Feb 25, 2019

Conversation

ThunderSoft123
Copy link
Contributor

Description

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ThunderSoft123
Copy link
Contributor Author

The test results are as follows(WIN7, run "mbed test -t GCC_ARM/ARM/IAR -m TT_M4G9"):
tt_m4g9_arm.txt
tt_m4g9_gcc_arm.txt
tt_m4g9_iar.txt

@cmonr cmonr requested a review from a team January 3, 2019 03:28
@bulislaw
Copy link
Member

bulislaw commented Jan 3, 2019

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2019

Thanks for the update ! The remaining rebase to resolve targets.json file conflict

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

https://github.com/ARMmbed/mbed-os/tree/0184da2a2912e4ae95ab658ba2548feca4d9ddad/targets/TARGET_TT/TARGET_TT_M4G9/Periph_Driver - this folder still contains some non licensed files ? gpio for instance, please review entire driver folder

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

@ThunderSoft123 Any update?

@gaoshaohhua
Copy link

@cmonr Our developer has finished the non licence problem, and if there are any other problems,we will do ASAP.(Sorry, our developer has not returned from the Spring Festival holiday. When he returns, we will confirm your question immediately.)

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 14, 2019

@ashok-rao Can you please review?

1 similar comment
@gaoshaohhua
Copy link

@ashok-rao Can you please review?

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments. Rest all LGTM! Thanks @gaoshaohhua

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2019

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 Please provide the details result. Thanks

@cmonr
Copy link
Contributor

cmonr commented Feb 22, 2019

@ThunderSoft123 The results can be found in the comment, inside of the artifacts link.

@ThunderSoft123
Copy link
Contributor Author

@cmonr I can't access the "Build artifacts".

@gaoshaohhua
Copy link

@cmonr We can not access the [Build artifacts],,so can you provide the total log or error information to us?(You do not seems to have open the access to us)

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2019

@ThunderSoft123 @gaoshaohhua This is the first time someone reports this issue. What link are you trying (just in case, please paste here the url), and what the url reports - what error are you getting? The links should be public, stored in aws.

I uploaded some results here (IAR and GCC ARM).

mbed-os_test_compile_TT_M4G9_IAR.tar.gz
mbed-os_test_compile_TT_M4G9_GCC_ARM.tar.gz

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2019

cc @mbed-os-test To review why build logs can't be accessed

@ThunderSoft123 Migth be worth creating separate ticket for this, we will review and fix !

@gaoshaohhua
Copy link

@mbed-os-test @0xc0170 @cmonr Please wait a moment,We are checking the issue where we can not access your page by our IT.

@ThunderSoft123
Copy link
Contributor Author

@cmonr Please restart CI test.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

@cmonr cmonr merged commit 1d2212d into ARMmbed:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants