Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform TT_M4G9 #9224

Merged
merged 9 commits into from Feb 25, 2019

Conversation

Projects
None yet
8 participants
@ThunderSoft123
Copy link
Contributor

commented Jan 3, 2019

Description

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ThunderSoft123

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

The test results are as follows(WIN7, run "mbed test -t GCC_ARM/ARM/IAR -m TT_M4G9"):
tt_m4g9_arm.txt
tt_m4g9_gcc_arm.txt
tt_m4g9_iar.txt

@cmonr cmonr added the needs: review label Jan 3, 2019

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Jan 3, 2019

@bulislaw

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

@cmonr cmonr requested review from MarceloSalazar, screamerbg and ashok-rao Jan 3, 2019

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Thanks for the update ! The remaining rebase to resolve targets.json file conflict

Show resolved Hide resolved targets/TARGET_TT/TARGET_TT_M4G9/device/system_TMPM4G9.c Outdated
Show resolved Hide resolved targets/TARGET_TT/TARGET_TT_M4G9/device/cmsis_nvic.h
Show resolved Hide resolved targets/TARGET_TT/TARGET_TT_M4G9/device/cmsis.h
Show resolved Hide resolved targets/TARGET_TT/TARGET_TT_M4G9/device/system_TMPM4G9.h Outdated

@ThunderSoft123 ThunderSoft123 force-pushed the ThunderSoft123:master branch Jan 16, 2019

Show resolved Hide resolved targets/TARGET_TT/TARGET_TT_M4G9/Periph_Driver/inc/txz_i2c_api.h Outdated
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

https://github.com/ARMmbed/mbed-os/tree/0184da2a2912e4ae95ab658ba2548feca4d9ddad/targets/TARGET_TT/TARGET_TT_M4G9/Periph_Driver - this folder still contains some non licensed files ? gpio for instance, please review entire driver folder

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@ThunderSoft123 Any update?

@gaoshaohhua

This comment has been minimized.

Copy link

commented Feb 12, 2019

@cmonr Our developer has finished the non licence problem, and if there are any other problems,we will do ASAP.(Sorry, our developer has not returned from the Spring Festival holiday. When he returns, we will confirm your question immediately.)

@cmonr cmonr added needs: review and removed needs: work labels Feb 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

@ashok-rao Can you please review?

1 similar comment
@gaoshaohhua

This comment has been minimized.

Copy link

commented Feb 18, 2019

@ashok-rao Can you please review?

@ashok-rao
Copy link
Contributor

left a comment

Few minor comments. Rest all LGTM! Thanks @gaoshaohhua

@cmonr cmonr added needs: work and removed needs: CI labels Feb 21, 2019

@ThunderSoft123

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@0xc0170 Please provide the details result. Thanks

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@ThunderSoft123 The results can be found in the comment, inside of the artifacts link.

@ThunderSoft123

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@cmonr I can't access the "Build artifacts".

@gaoshaohhua

This comment has been minimized.

Copy link

commented Feb 22, 2019

@cmonr We can not access the [Build artifacts],,so can you provide the total log or error information to us?(You do not seems to have open the access to us)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@ThunderSoft123 @gaoshaohhua This is the first time someone reports this issue. What link are you trying (just in case, please paste here the url), and what the url reports - what error are you getting? The links should be public, stored in aws.

I uploaded some results here (IAR and GCC ARM).

mbed-os_test_compile_TT_M4G9_IAR.tar.gz
mbed-os_test_compile_TT_M4G9_GCC_ARM.tar.gz

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

cc @mbed-os-test To review why build logs can't be accessed

@ThunderSoft123 Migth be worth creating separate ticket for this, we will review and fix !

@gaoshaohhua

This comment has been minimized.

Copy link

commented Feb 22, 2019

@mbed-os-test @0xc0170 @cmonr Please wait a moment,We are checking the issue where we can not access your page by our IT.

@ThunderSoft123 ThunderSoft123 force-pushed the ThunderSoft123:master branch to 3c1d938 Feb 25, 2019

panyz0725@thundersoft.com
@ThunderSoft123

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

@cmonr Please restart CI test.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 25, 2019

@cmonr cmonr merged commit 1d2212d into ARMmbed:master Feb 25, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9987 cycles (-220 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.