Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration options for STM_EMAC buffer counts #9307

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
8 participants
@mtomczykmobica
Copy link
Contributor

mtomczykmobica commented Jan 9, 2019

Description

Configuration options for STM_EMAC buffer counts.

Add configurable options for STM_EMAC buffer. For all STM_EMAC board targets added mbed_lib.jeson with configurable: eth-rxbufnb and eth-txbufnb used in stm32f1xx_hal_conf.h.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

@ciarmcom ciarmcom requested review from SeppoTakalo and ARMmbed/mbed-os-maintainers Jan 9, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 9, 2019

@jeromecoutant
Copy link
Contributor

jeromecoutant left a comment

I would propose to use the same lib name for all.

"name": "stm32-emac",

Thx

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Jan 9, 2019

What is "ONME-3949" ?
Thx

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Jan 9, 2019

What is "ONME-3949" ?
Thx

Internal Jira ticket number.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 9, 2019

Is it that important to have it in the title ? Fine to be referenced in the commit msg or description here, isn't that sufficient ?

@mtomczykmobica mtomczykmobica changed the title ONME-3949 Configuration options for STM_EMAC buffer counts Configuration options for STM_EMAC buffer counts Jan 9, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Jan 9, 2019

Or use the github issue number behind this internal reference....

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Jan 9, 2019

Is it that important to have it in the title ? Fine to be referenced in the commit msg or description here, isn't that sufficient ?

ok, changed.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 15, 2019

@ARMmbed/team-st-mcd Please review

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Jan 15, 2019

@ARMmbed/team-st-mcd Please review

I have already reviewed it and propose to use the same lib name for all.

"name": "stm32-emac",

Thx

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 12, 2019

@mtomczykmobica Any updates?

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Feb 12, 2019

@jeromecoutant I prefer to leave different names for different targets.

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Feb 12, 2019

After a another thought on this,
Can we instead move the mbed_lib.json up for couple of levels so that all stm32-emac drivers share one .lib file?
Then all variables can have same name and be overridden by target.

So basically this whole change would be
features/netsocket/emac-drivers/TARGET_STM_EMAC/mbed_lib.json:

{
    "name": "stm32-emac",
    "config": {
        "eth-rxbufnb": 4,
        "eth-txbufnb": 4
    },
    "target_overrides": {
        "NUCLEO_F207ZG": {
            "eth-rxbufnb": 1,
            "eth-txbufnb": 4
        }
    }
}

And within the header files, just use the generic name:

#define ETH_RXBUFNB                       MBED_CONF_STM32_EMAC_ETH_RXBUFNB

No need for if-def as the mbed_lib.json always provides values for those.

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-3949 branch Feb 12, 2019

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Feb 12, 2019

@SeppoTakalo , @jeromecoutant requested changes added.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 12, 2019

Waiting for @ARMmbed/team-st-mcd review

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 18, 2019

Test run: FAILED

Summary: 6 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-3949 branch to a5f93e0 Feb 19, 2019

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Feb 19, 2019

Fixes for builds error.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 19, 2019

CI was restarted

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 19, 2019

@0xc0170 0xc0170 merged commit 723236f into ARMmbed:master Feb 19, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10157 cycles (+1003 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.