-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug for RDA UNO_91H:calling us ticker functions without init. #9318
Conversation
Can you review travis build failure in docs: Another request is to use Description to describe your pull request. I'll paste here an example
|
Please specify the target name in commit message and Pull-Request title. Otherwise this is a bit misleading. Also, please submit a test results when running Socket, Wifi + EMAC tests against current Mbed OS master. |
@caixue1102 Let us know if you need any assistance |
056b372
to
44421cd
Compare
@0xc0170 We need fix a TRNG bug before support wifi for UNO_91H. Please help review it. Thanks. |
Looks fine to me, one question: why are we initalizing us ticker in TRNG ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple fix but not clear to a reader how is TRNG related to us ticker - what bug is this fixing - can you add this to the commit msg?
Travis failure will be fixed via rebase, we can help there once the last fix is on master (today)
We use us ticker delay to waiting for TRNG seed ready, and we do this to avoid calling us ticker functions without us_ticker_init. |
44421cd
to
4e8b256
Compare
We will rebase once travis is done and start CI |
solution: init us ticker when init TRNG.
NOTE: This PR has now been rebased. If this was made in error, feel free to force-push your local branch to restore the PR. |
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Thank you for the test, but I can't find the failed test job in the link, so that I don't know the relationship with my commit. Could you please give me some pointers. |
You can find it linked above via Build artifacts. I restarted teh test as this was an issue with CI job itself, restarted |
CI restarted |
Description
fix bug for RDA UNO_91H:calling us ticker functions without init.
solution: init us ticker when init TRNG, because we use us ticker read to delay and wait for TRNG seed ready.
Pull request type
Reviewers