STM32H7 : add CAN support #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant, thank you for your changes. |
jeromecoutant
force-pushed
the
PR_H7CAN
branch
from
8eed91d
to
f4db13b
Compare
0xc0170
reviewed
Jan 21, 2019
targets/TARGET_STM/can_api.c
Outdated
| TxHeader.MessageMarker = 0; | ||
|
|
||
| if (HAL_FDCAN_AddMessageToTxFifoQ(&obj->CanHandle, &TxHeader, msg.data) != HAL_OK) { | ||
| // printf("*** can_write error %x\n", HAL_FDCAN_GetError(&obj->CanHandle)); |
targets/TARGET_STM/can_api.c
Outdated
|
|
||
| FDCAN_RxHeaderTypeDef RxHeader = {0}; | ||
| if (HAL_FDCAN_GetRxMessage(&obj->CanHandle, FDCAN_RX_FIFO0, &RxHeader, msg->data) != HAL_OK) { | ||
| error("HAL_FDCAN_GetRxMessage error\n"); |
There was a problem hiding this comment.
Should it used mbed_error?
There was a problem hiding this comment.
HAL_FDCAN_GetRxMessage should not return 0 after that HAL_FDCAN_GetRxFifoFillLevel has returned something.
There was a problem hiding this comment.
I am just wondering if we should use mbed_error that can contain more information rather than older error function (will print unknown error).
@SenRamakri Can you review this, we still use error in targets implementation?
targets/TARGET_STM/can_api.c
Outdated
| } | ||
|
|
||
|
|
||
| // TODO Add other interrupts ? |
jeromecoutant
force-pushed
the
PR_H7CAN
branch
from
f4db13b
to
d0cdc34
Compare
0xc0170
approved these changes
Jan 23, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
STM32H7 family is supporting now CAN FD feature.
So previous CAN implementation for other STM32 families is not compatible.
This patch is enabling CAN for NUCLEO_H743ZI
Tested manually as there is no CAN mbed-os test.
Thx
Pull request type