-
Notifications
You must be signed in to change notification settings - Fork 3k
Corrected the targets value in json file as CI uses real board names #9462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@deepikabhavnani, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of maintainer's file than a tools file, but looks ok. It does looks like sometimes a K64F
was chosen instead of a K66F
, any reason for that? Or more general, how come certain targets are included for certain examples and not for others?
All of the test are socket related, so instead of performing test on single target selected different ones for each test. |
CI started |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
Restarted CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous values were not valid, and only these updated targets were selected anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
CI restarted, it timeouted |
CI job restarted: It appears to have timed out, but not sure 100%... |
Description
Sockets examples were not tested in CI, as CI uses real board names and not macros.
Pull request type
Reviewers
@OPpuolitaival