Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Component SD test by formatting SD Card #9484

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Start Component SD test by formatting SD Card #9484

merged 1 commit into from
Jan 24, 2019

Conversation

offirko
Copy link
Contributor

@offirko offirko commented Jan 24, 2019

Fix Jira: IOTSTOR-752

Description

Start Component SD test by formatting SD Card, otherwise FATFS mount might fail

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team January 24, 2019 12:00
@ciarmcom
Copy link
Member

@offirko, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

theamirocohen
theamirocohen approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@theamirocohen theamirocohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NirSonnenschein
Copy link
Contributor

starting CI

@0xc0170 0xc0170 changed the title Start Component SD test by formatting SD Card, otherwise FATFS mount might fail Start Component SD test by formatting SD Card Jan 24, 2019
0xc0170
0xc0170 approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shortened the title (should be within 50 characters limit, details are in the commit msgs).

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 1b1c108 into ARMmbed:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@theamirocohen theamirocohen theamirocohen approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@offirko @ciarmcom @NirSonnenschein @mbed-ci @0xc0170 @theamirocohen @cmonr