Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBLOX_C030: Fix modem reset functionality #9485

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
6 participants
@fahim-ublox
Copy link
Contributor

fahim-ublox commented Jan 24, 2019

Description

Fixed modem reset functionality to avoid low time to trigger module switch off

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@RobMeades

@RobMeades
Copy link
Contributor

RobMeades left a comment

FTAOD, I approve this.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 24, 2019

@fahim-ublox, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jan 24, 2019

@fahim-ublox

This comment has been minimized.

Copy link
Contributor Author

fahim-ublox commented Jan 28, 2019

@screamerbg

This comment has been minimized.

Copy link
Member

screamerbg commented Jan 30, 2019

LGTM

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 30, 2019

CI started

@0xc0170 0xc0170 changed the title Fixed modem reset functionality to avoid low time to trigger module s… UBLOX_C030: Fix modem reset functionality Jan 30, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 30, 2019

I edited the title to be <50 char , please review

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 30, 2019

@0xc0170 0xc0170 merged commit 85cc30a into ARMmbed:master Jan 31, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10446 cycles (+1197 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 13, 2019

@fahim-ublox I also edited the description, we've noticed it was commented out (using <!-- -->)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.