Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused yotta module metadata #9499

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

bridadan commented Jan 24, 2019

Description

These files are being cleaned up because they can cause some confusion (see #6417, ARMmbed/mbed-os-5-docs#462 (comment)). We do not use yotta to build Mbed OS 5, so I am removing the module.json metadata files.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-
@SeppoTakalo

@ciarmcom ciarmcom requested review from pan- , SeppoTakalo and ARMmbed/mbed-os-maintainers Jan 24, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 24, 2019

@pan-

pan- approved these changes Jan 25, 2019

Copy link
Member

pan- left a comment

All good, it was needed the first year of mbed OS 5 to maintain compatibility with the mbed OS 3 API. It is not anymore.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 28, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 28, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Jan 28, 2019

@cmonr cmonr merged commit 66cda8a into ARMmbed:master Jan 28, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10013 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.