Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSOC6.py: generate hex files with 16 bytes per row #9509

Merged
merged 1 commit into from Jan 28, 2019
Merged

PSOC6.py: generate hex files with 16 bytes per row #9509

merged 1 commit into from Jan 28, 2019

Conversation

vmedcy
Copy link
Contributor

@vmedcy vmedcy commented Jan 25, 2019

Description

PSOC6.py post binary hook implemented for FUTURE_SEQUANA board produces Intelhex file with 64 bytes per row. ARM DAPLink implementation can handle up to 32 bytes per row (intelhex.c).
Produce hex files with 16 bytes per row: this is compatible with Cypress and Future boards.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@lrusinowicz @theotherjimmy

DAPLink implementation on Cypress kits cannot handle hex files
with 64 bytes per row: refer to https://github.com/ARMmbed/DAPLink,
source/daplink/drag-n-drop/intelhex.c, hex_line_t struct, data field.
@ciarmcom ciarmcom requested review from theotherjimmy and a team January 25, 2019 20:00
@ciarmcom
Copy link
Member

@vmedcy, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team January 25, 2019 20:00
@cmonr
Copy link
Contributor

cmonr commented Jan 25, 2019

@lrusinowicz Please review as well.

@cmonr
Copy link
Contributor

cmonr commented Jan 25, 2019

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 28, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit e965aa6 into ARMmbed:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants