Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yotta and minar references in NCS36510 #9526

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

bridadan commented Jan 28, 2019

Description

Doing some clean up of some old Mbed OS 3 references in this code base. The references can cause some confusion (see #6417, ARMmbed/mbed-os-5-docs#462 (comment)).

FYI @maclobdell

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 29, 2019

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jan 29, 2019

@0xc0170 0xc0170 requested a review from ARMmbed/team-onsemi Jan 29, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 29, 2019

Nice clean-ups 👍

@cmonr cmonr requested a review from maclobdell Jan 29, 2019

@cmonr

cmonr approved these changes Jan 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 29, 2019

Will wait for OK from either @Team-ONSemi or @maclobdell before continuing.

@bridadan

This comment has been minimized.

Copy link
Contributor Author

bridadan commented Feb 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 2, 2019

CI started.

Still waiting for reviews, but intended to get this CI-OK'd in the meanwhile

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 2, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 2, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@maclobdell

This comment has been minimized.

Copy link
Contributor

maclobdell commented Feb 4, 2019

looks good to me. @danclement - are you okay with this clean up?

@maclobdell
Copy link
Contributor

maclobdell left a comment

YOTTA and MINAR are not supported any longer, so removing references should have no impact.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 5, 2019

@0xc0170 , as this has passed CI and seems to be well reviewed is it "ready"?

@0xc0170 0xc0170 merged commit ad97936 into ARMmbed:master Feb 5, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9308 cycles (-1241 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.