-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32 Serial Flow Control #9534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, thank you for your changes. |
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
UARTName uart_rts = (UARTName)pinmap_peripheral(rxflow, PinMap_UART_RTS); | ||
UARTName uart_cts = (UARTName)pinmap_peripheral(txflow, PinMap_UART_CTS); | ||
MBED_ASSERT((UARTName)pinmap_merge(uart_rts, obj_s->uart) != (UARTName)NC); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this assert ? What will happen in the release build if asserts is not active, wont be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
I have updated the code
Crash occured when RTS=CTS=NC Now we chek if used pins are the same UART as TX and RX
0529c4a
to
eec7126
Compare
CI started, Travis restarted |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Description
This fixes #9525
Crash occurred when the flow control is set to disabled,
i.e. when serial_set_flow_control function was called with RTS and CTS values equal to "NC"
Correction is to check that used pin is using the same UART instance as TX and RX.
Pull request type
Reviewers
@cwq9999 @LMESTM