STM32 Serial Flow Control #9534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMESTM
approved these changes
Jan 29, 2019
|
@jeromecoutant, thank you for your changes. |
cmonr
approved these changes
Jan 29, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
0xc0170
reviewed
Jan 30, 2019
| UARTName uart_rts = (UARTName)pinmap_peripheral(rxflow, PinMap_UART_RTS); | ||
| UARTName uart_cts = (UARTName)pinmap_peripheral(txflow, PinMap_UART_CTS); | ||
| MBED_ASSERT((UARTName)pinmap_merge(uart_rts, obj_s->uart) != (UARTName)NC); |
There was a problem hiding this comment.
why is this assert ? What will happen in the release build if asserts is not active, wont be merged.
There was a problem hiding this comment.
Good catch.
I have updated the code
Crash occured when RTS=CTS=NC Now we chek if used pins are the same UART as TX and RX
jeromecoutant
force-pushed
the
PR_FLOW
branch
from
0529c4a to
eec7126
Compare
|
CI started, Travis restarted |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #9525
Crash occurred when the flow control is set to disabled,
i.e. when serial_set_flow_control function was called with RTS and CTS values equal to "NC"
Correction is to check that used pin is using the same UART instance as TX and RX.
Pull request type
Reviewers
@cwq9999 @LMESTM