Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSTM32 Serial Flow Control #9534
Conversation
jeromecoutant
referenced this pull request
Jan 29, 2019
Closed
Flow control fails on STM32L476 #9525
LMESTM
approved these changes
Jan 29, 2019
ciarmcom
requested a review
from ARMmbed/mbed-os-maintainers
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
@jeromecoutant, thank you for your changes. |
ciarmcom
added
the
needs: review
label
Jan 29, 2019
cmonr
approved these changes
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
CI started |
cmonr
added
needs: CI
release-version: 5.11.4
and removed
needs: review
labels
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Jan 30, 2019
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
cmonr
added
ready for merge
and removed
needs: CI
labels
Jan 30, 2019
0xc0170
reviewed
Jan 30, 2019
targets/TARGET_STM/TARGET_STM32F0/serial_device.c
Outdated
| UARTName uart_rts = (UARTName)pinmap_peripheral(rxflow, PinMap_UART_RTS); | ||
| UARTName uart_cts = (UARTName)pinmap_peripheral(txflow, PinMap_UART_CTS); | ||
| MBED_ASSERT((UARTName)pinmap_merge(uart_rts, obj_s->uart) != (UARTName)NC); |
This comment has been minimized.
This comment has been minimized.
0xc0170
Jan 30, 2019
Member
why is this assert ? What will happen in the release build if asserts is not active, wont be merged.
This comment has been minimized.
This comment has been minimized.
0xc0170
added
needs: review
and removed
ready for merge
labels
Jan 30, 2019
jeromecoutant
force-pushed the
jeromecoutant:PR_FLOW
branch
to
eec7126
Jan 31, 2019
cmonr
added
needs: CI
and removed
needs: review
labels
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
|
CI started, Travis restarted |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Feb 1, 2019
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
cmonr
added
ready for merge
and removed
needs: CI
labels
Feb 1, 2019
0xc0170
merged commit ed53fe1
into
ARMmbed:master
Feb 4, 2019
27 checks passed
continuous-integration/jenkins/pr-head
This commit looks good
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jenkins-ci/build-ARM
Success
Details
jenkins-ci/build-ARMC6
Success
Details
jenkins-ci/build-GCC_ARM
Success
Details
jenkins-ci/build-IAR
Success
Details
jenkins-ci/cloud-client-test
Success
Details
jenkins-ci/dynamic-memory-usage
RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter
Success
Details
jenkins-ci/greentea-test
Success
Details
jenkins-ci/mbed2-build-ARM
Success
Details
jenkins-ci/mbed2-build-GCC_ARM
Success
Details
jenkins-ci/mbed2-build-IAR
Success
Details
jenkins-ci/unittests
Success
Details
travis-ci/astyle
Local astyle testing has passed
Details
travis-ci/docs
Local docs testing has passed
Details
travis-ci/doxy-spellcheck
Local doxy-spellcheck testing has passed
Details
travis-ci/events
Passed, runtime is 10215 cycles
Details
travis-ci/gitattributestest
Local gitattributestest testing has passed
Details
travis-ci/include_check
Local include_check testing has passed
Details
travis-ci/licence_check
Local licence_check testing has passed
Details
travis-ci/littlefs
Passed, code size is 8408B
Details
travis-ci/psa-autogen
Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7
Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5
Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6
Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7
Local tools-py3.7 testing has passed
Details
0xc0170
removed
the
ready for merge
label
Feb 4, 2019
jeromecoutant
deleted the
jeromecoutant:PR_FLOW
branch
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jeromecoutant commentedJan 29, 2019
Description
This fixes #9525
Crash occurred when the flow control is set to disabled,
i.e. when serial_set_flow_control function was called with RTS and CTS values equal to "NC"
Correction is to check that used pin is using the same UART instance as TX and RX.
Pull request type
Reviewers
@cwq9999 @LMESTM