[Wio 3G] Modified pin map #9556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ytsuboi, thank you for your changes. |
0xc0170
requested changes
Jan 30, 2019
| // Not connected | ||
| NC = (int)0xFFFFFFFF, | ||
|
|
||
| PA_0 = 0x00, |
| LED4 = PB_14, | ||
| LED_RED = LED2, | ||
| USER_BUTTON = PC_13, | ||
| LED1 = NC, |
There was a problem hiding this comment.
Why are these being changed to NC? Can you add this to the tcommit message?
Why and how are this being modified, how this fixes the bug?
There was a problem hiding this comment.
The LED on Wio 3G is not traditional LED, so LED1-4 doesn't have any meaning. However, we need to have definition of LED1-4. This is the reason why we tried to change like this. ( Finally, we changed approach for this issue. )
* Remove unused Peripheral Pins definitions and add UART_1 TXD/RXD pins (fix #9026) for the Wio 3G board * Remove/Fix unused PinName definitions for the Wio 3G board from the PinNames enum
0xc0170
approved these changes
Feb 4, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing issue #9026
Pull request type
Reviewers