Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wio 3G] Modified pin map #9556

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@ytsuboi
Copy link
Contributor

ytsuboi commented Jan 30, 2019

Description

Fixing issue #9026

Pull request type

[ x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jan 30, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 30, 2019

@ytsuboi, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

// Not connected
NC = (int)0xFFFFFFFF,

PA_0 = 0x00,

This comment has been minimized.

@0xc0170

0xc0170 Jan 30, 2019

Member

misaligned code

This comment has been minimized.

@ytsuboi

ytsuboi Feb 4, 2019

Author Contributor

Approach changed.

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_WIO_3G/PinNames.h Outdated
LED4 = PB_14,
LED_RED = LED2,
USER_BUTTON = PC_13,
LED1 = NC,

This comment has been minimized.

@0xc0170

0xc0170 Jan 30, 2019

Member

Why are these being changed to NC? Can you add this to the tcommit message?

Why and how are this being modified, how this fixes the bug?

This comment has been minimized.

@ytsuboi

ytsuboi Feb 4, 2019

Author Contributor

The LED on Wio 3G is not traditional LED, so LED1-4 doesn't have any meaning. However, we need to have definition of LED1-4. This is the reason why we tried to change like this. ( Finally, we changed approach for this issue. )

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 30, 2019

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_3g-9026 branch 2 times, most recently Jan 31, 2019

[Wio 3G] Modified pin map
* Remove unused Peripheral Pins definitions and add UART_1 TXD/RXD pins (fix #9026)  for the Wio 3G board
* Remove/Fix unused PinName definitions for the Wio 3G board from the PinNames enum

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_3g-9026 branch to a2f1e9c Feb 4, 2019

@0xc0170

0xc0170 approved these changes Feb 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 4, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 4, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 4, 2019

@0xc0170 0xc0170 merged commit 346ebe6 into ARMmbed:master Feb 4, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10686 cycles (+163 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 4, 2019

@ytsuboi ytsuboi deleted the SeeedJP:hal-wio_3g-9026 branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.