Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK fixes #9570

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
7 participants
@VeijoPesonen
Copy link
Contributor

VeijoPesonen commented Jan 31, 2019

Description

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK execution time limit

Test case is allowed to take not more than a half what has been given
for the whole UDP suite.

UDP test cases reorganized so that the longest running ones are
executed last.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-ipcore
@TeemuKultala
@mirelachirica
@AriParkkila
@kivaisan

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK restores non-blocking
Fixes a bug where after dropping bad packets receiver doesn't restore
the socket back to non-blocking state as it's supposed to.

@ciarmcom ciarmcom requested review from AriParkkila , kivaisan , mirelachirica , TeemuKultala and ARMmbed/mbed-os-maintainers Jan 31, 2019

@ciarmcom

This comment has been minimized.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-ipcore Jan 31, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

VeijoPesonen commented Feb 4, 2019

@0xc0170 please review.

@0xc0170

0xc0170 approved these changes Feb 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 4, 2019

Please fix astyle failures

tests-netsocket-udp: UDPSOCKET_ECHOTEST_NONBLOCK execution time limit
Test case is allowed to take not more than a half what has been given
to the whole UDP suite.

UDP test cases reorganized so that the longest running ones are
executed last.

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:bugfix-tests-netsocket-udp_udpsocket_echotest_nonblock branch to df3cdaa Feb 4, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

VeijoPesonen commented Feb 7, 2019

@0xc0170 astyle fixes applied.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

Ah, reviewers bot got to this PR after others had already reviewed.

Thus a couple of the reviewers are supluferous.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Feb 11, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 12, 2019

#9570 (comment)

@ARMmbed/mbed-os-maintainers If y'all agree with this, feel free to merge.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 12, 2019

@VeijoPesonen As you requested explicitly these

@TeemuKultala
@mirelachirica
@AriParkkila
@kivaisan

None of above reviewed, is any required or sufficient with already reviews ?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

VeijoPesonen commented Feb 12, 2019

@0xc0170 it was more as for their information. Enough many persons have already reviewed and approved the changes.

@0xc0170 0xc0170 merged commit 0915097 into ARMmbed:master Feb 12, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9342 cycles (+27 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:bugfix-tests-netsocket-udp_udpsocket_echotest_nonblock branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.