Fix SharedPtr::reset #9580
Merged
Fix SharedPtr::reset #9580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharedPtr::reset did not actually set the stored pointer value. Correct this, with other minor tidies: * Ensure counter is set to NULL if pointer is reset to NULL * Be consistent about not clearing pointers in decrement_counter().
|
@kjbracey-arm, thank you for your changes. |
pan-
approved these changes
Feb 1, 2019
deepikabhavnani
approved these changes
Feb 1, 2019
|
CI started |
cmonr
approved these changes
Feb 2, 2019
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
0xc0170
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SharedPtr::resetdid not actually set the stored pointer value.Correct this, with other minor tidies:
decrement_counter().Pull request type
Reviewers