Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greentea Socket test improvements #9582

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
8 participants
@michalpasztamobica
Copy link
Contributor

michalpasztamobica commented Feb 1, 2019

Description

  1. The bind tests were amended to take IPv6-specific steps.
  2. UDPSOCKET_RECV_TIMEOUT was occasionally failing for nanostack with an "off-by-one" error. I followed the fix applied to TCP version of this test a couple of months ago and increased the tolerance from 50 to 51. This is to much extent caused by rounding error in the assertion function, but sometimes the time really is slightly higher than 50 ms. I suppose the time measurement might be inaccurate in more ways than just the overly simplistic rounding and it makes sense to add a minimal grace period, like we did for TCP_RECV_TIMEOUT.
  3. I added a debug message that could help us check why are ASYNCHRONOUS_DNS_NON_ASYNC_AND_ASYNC and ASYNCHRONOUS_DNS_CANCEL failing from time to time. I couldn't reproduce the issue locally, it happens rather rarely.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen
@KariHaapalehto
@mtomczykmobica

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:greentea_socket_improvements branch to b3fd8a9 Feb 1, 2019

@ciarmcom ciarmcom requested review from KariHaapalehto , mtomczykmobica , SeppoTakalo , VeijoPesonen and ARMmbed/mbed-os-maintainers Feb 1, 2019

@ciarmcom

This comment has been minimized.

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

michalpasztamobica commented Feb 11, 2019

@0xc0170 , this PR is already approved. Could you change the label, please?

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 11, 2019

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

alekla01 commented Feb 11, 2019

Restarted greentea-test

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 11, 2019

@cmonr cmonr merged commit 5c4d5e3 into ARMmbed:master Feb 12, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+12 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 8958 cycles (-1565 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.