Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Arduino form factor #9593

Merged
merged 5 commits into from Feb 5, 2019

Conversation

Projects
None yet
7 participants
@c1728p9
Copy link
Contributor

c1728p9 commented Feb 2, 2019

Description

Remove ARDUINO from supported_form_factors on devices which physically do not have the Arduinoform factor. Also ensure that all Arduino pins are defined for targets with the Arduino form factor, even if they are set to NC.

This PR is a subset of the pinmap work in #9449.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

c1728p9 added some commits Feb 1, 2019

Remove ARDUINO form factor from FF1705_L151CC
The FF1705_L151CC does not have the following pins
D4, D5, D6, D7, D8, D9, A2, A3, A4, A5 so remove the ARDUINO form
factor from it.
Remove ARDUINO form factor from RBLAB_BLENANO2
Remove the ARDUINO form factor from the RBLAB_BLENANO2 since it
does not have D11, D12, D14, D15 defined and does not physically have
the arduino form factor.
Remove ARDUINO form factor for nano devices
Remove ARDUINO from supported form factors on devices which have the
physical form factor of the arduino nano.
Define A0 to NC for the TARGET_KW41Z
Set A0 to NC so it is defined on the KW41Z platform.
Define Arduino pins for the LPC812
Define the unconnected Arduino pins to NC so they are all defined.

@c1728p9 c1728p9 referenced this pull request Feb 2, 2019

Merged

Pinmap extensions #9449

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 2, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 2, 2019

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested review from ARMmbed/team-nxp Feb 4, 2019

@mmahadevan108
Copy link
Contributor

mmahadevan108 left a comment

Thank you

@0xc0170

0xc0170 approved these changes Feb 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 4, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 4, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d7a442b into ARMmbed:master Feb 5, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9884 cycles (-639 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.