Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SERIAL_FC on devices which don't support it #9594

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@c1728p9
Copy link
Contributor

c1728p9 commented Feb 2, 2019

Description

Remove SERIAL_FC from device_has for the targets which do not have code to make use of flow control.

This PR is a subset of the pinmap work in #9449.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

c1728p9 added some commits Feb 2, 2019

Remove SERIAL_FC from the NCS36510
The NCS36510 does not support flow control in its serial driver so it
should not have SERIAL_FC in device_has.
Remove SERIAL_FC from the ARM_IOTSS_BEID
The ARM_IOTSS_BEID does not support flow control in its serial driver so it
should not have SERIAL_FC in device_has.
Remove SERIAL_FC from the MPS2 family
The MPS2 family does not support flow control in its serial driver so it
should not have SERIAL_FC in device_has.

@c1728p9 c1728p9 referenced this pull request Feb 2, 2019

Merged

Pinmap extensions #9449

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 2, 2019

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 2, 2019

@0xc0170

0xc0170 approved these changes Feb 4, 2019

Copy link
Member

0xc0170 left a comment

Nice cleanup, the pinmap work is helping to catch all these? 👍

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 4, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 4, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit b4e09cf into ARMmbed:master Feb 4, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10485 cycles (-38 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.