Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare metal mbed_lib updates #9628

Merged
merged 2 commits into from Feb 14, 2019

Conversation

@orenc17
Copy link
Contributor

commented Feb 6, 2019

Description

Create missing mbed_lib.json for the following libs:

  • kv-config
  • storage
  • direct-access-devicekey
  • filesystemstore
  • kv-global-api
  • kv-map
  • tdbstore
  • PSA

Relays on #9561

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @davidsaada @yossi2le

Release notes

Make the following modules comply with bare-metal:

  1. kv-config
  2. storage
  3. direct-access-devicekey
  4. filesystemstore
  5. kv-global-api
  6. kv-map
  7. tdbstore
  8. PSA-services

@ciarmcom ciarmcom requested review from davidsaada, theotherjimmy, yossi2le and ARMmbed/mbed-os-maintainers Feb 6, 2019

"storage_type": "TDB_INTERNAL"
},
"NUCLEO_F411RE": {
"storage_type": "TDB_INTERNAL"

This comment has been minimized.

Copy link
@jeromecoutant

jeromecoutant Feb 6, 2019

Contributor

Why this ?

This comment has been minimized.

Copy link
@orenc17

orenc17 Feb 6, 2019

Author Contributor

that's was in the original mbed_lib.json

This comment has been minimized.

Copy link
@mikisch81

mikisch81 Feb 7, 2019

Contributor

@jeromecoutant Could you please move this comment to #9561?

@theotherjimmy
Copy link
Contributor

left a comment

Looks fine to me. Should I close the prior PR?

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

@theotherjimmy merge your PR first and then i'll rebase

features/nanostack/mbed_lib.json Outdated
@@ -0,0 +1,3 @@
{
"name": "nanostack-upper"

This comment has been minimized.

Copy link
@SeppoTakalo

SeppoTakalo Feb 6, 2019

Contributor

I'll propose "nanostack-adaptation"

This comment has been minimized.

Copy link
@orenc17

orenc17 Feb 6, 2019

Author Contributor

i believe that this change is in @theotherjimmy original PR

This comment has been minimized.

Copy link
@theotherjimmy

theotherjimmy Feb 6, 2019

Contributor

@SeppoTakalo Actually, that's a hack that I have not yet removed. Could you comment on the appropriate folders to label such that we can completely exclude nanostack code from the build?

This comment has been minimized.

Copy link
@SeppoTakalo

SeppoTakalo Feb 6, 2019

Contributor

Do you mean that all folders within /features/nanostack/ should have their own mbed_lib.json files?

This comment has been minimized.

Copy link
@theotherjimmy

theotherjimmy Feb 6, 2019

Contributor

Perhaps. It depends on what you would consider a complete "library", that could be turned on/off as one. If the code within the subdirectories in nanostack can be enabled independently, then it would make sense to have mbed_lib.json in the root so that a user could use requires on that library.

This comment has been minimized.

Copy link
@SeppoTakalo

SeppoTakalo Feb 7, 2019

Contributor

image

Does this image help?

There are clear dependencies that can be expressed, so maybe it makes sense to all components being separate.

nanostack-eventloop is actually used also with Mbed Client.

Couple of helper libraries also missing from the picture:

  • features/frameworks/mbed-client-randlib (used by nanostack)
  • features/frameworks/mbed-coap (used by coap-service and Pelion Client)
  • features/frameworks/mbed-trace (used by Nanostack and Pelion Client, and various other libraries)
  • features/frameworks/nanostack-libservice (used by pretty much all Nanostack libraries and even Pelion Client).

So.. after a longer thought.. it seems that "features/nanostack" should be empty, no .lib files there, and all that is inside it, should have their equivalent .lib files.

This comment has been minimized.

Copy link
@mikisch81

mikisch81 Feb 7, 2019

Contributor

@SeppoTakalo @theotherjimmy Could you move this comment to #9561?

Show resolved Hide resolved features/nanostack/nanostack-interface/mbed_lib.json Outdated

@orenc17 orenc17 force-pushed the kfnta:bare-metal-updates branch Feb 6, 2019

@davidsaada
Copy link
Contributor

left a comment

LGTM (reviewing storage related changes).

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@SeppoTakalo @theotherjimmy
i've moved the problematic mbed_lib.json
now every directory inside features/nanostack has its own mbed_lib.json

@SeppoTakalo
Copy link
Contributor

left a comment

I can approve following .lib files:

  • mbed-client-cli
  • mbed-client-randlib
  • mbed-coap
  • nanostack-libservice
  • coap-service
  • nanostack-interface

Technically I cannot review changes to the tooling as I have not enough knowledge about the design.

@orenc17 orenc17 force-pushed the kfnta:bare-metal-updates branch 2 times, most recently Feb 7, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

One of the errors:

Scan: mbed-os-example-blinky
Traceback (most recent call last):
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/make.py", line 74, in wrapped_build_project
    src_dir, build_dir, mcu, *args, **kwargs
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/build_api.py", line 544, in build_project
    src_paths, toolchain, inc_dirs=inc_dirs)
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/resources/__init__.py", line 568, in scan_with_toolchain
    toolchain.config.load_resources(self)
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/config/__init__.py", line 1319, in load_resources
    raise ConfigException(message)
ConfigException: library 'psa' requires 'flashiap-block-device' which is not present
[mbed] ERROR: "/usr/bin/python" returned error.

orenc17 added some commits Feb 6, 2019

@orenc17 orenc17 force-pushed the kfnta:bare-metal-updates branch to b5e8492 Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

CI started (for now).

Still expected reviewer feedback

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@orenc17 Fyi, this will also need a Release Notes section.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@mbed-os-mesh @ARMmbed/mbed-os-pan @yossi2le Any thoughts?

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@yossi2le

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

I have taken a look at the changes and they look ok for me.
I will be happy to see this merged. Cause I am one of the clients for these changes :)

@0xc0170 0xc0170 removed request for ARMmbed/mbed-os-mesh Feb 14, 2019

@cmonr cmonr merged commit c07410d into ARMmbed:master Feb 14, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9189 cycles (-176 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.