Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not provide a default Pelion host address. #9635

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

bridadan commented Feb 6, 2019

Description

This moves the default pelion host address to be assigned by the cloud
sdk. It also cleans up the logic a bit to be shorter.

This pairs with ARMmbed/mbed-cli#840, though they aren't dependent on one other.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@ciarmcom ciarmcom requested review from theotherjimmy and ARMmbed/mbed-os-maintainers Feb 6, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 6, 2019

@bridadan, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170

0xc0170 approved these changes Feb 7, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor Author

bridadan commented Feb 7, 2019

@ARMmbed/mbed-os-maintainers I'm reevaluating the use of the environment variables here, can you please hold off on CI and merging this for now?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 11, 2019

Do not provide a default Pelion host address.
This moves the default pelion host address to be assigned by the cloud
sdk. It also cleans up the logic a bit to be shorter.

@bridadan bridadan force-pushed the bridadan:no_pelion_host branch to 3ff0ca4 Feb 11, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor Author

bridadan commented Feb 11, 2019

Ok I'm happy with this now. Now we let the Cloud SDK library handle all of the environment variables. If we catch an exception when passing the config to the Cloud SDK, it means and API key wasn't supplied, so we catch the original exception and make the message a bit clearer with a call to action (mbed config ...).

@aashishc1988 could you review this change? It's a follow up to your PR here: ARMmbed/mbed-cli#838

This should fix #8144 as well as IOTCORE-867.

@aashishc1988
Copy link
Contributor

aashishc1988 left a comment

Looks great!

@cmonr

cmonr approved these changes Feb 11, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

CI started while we wait on the primarily requested reviewer.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: review labels Feb 15, 2019

@cmonr cmonr merged commit 6278ed6 into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10346 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.