Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
ESP8266: connect() checks errors from ESP chip #9639
ESP8266Interface::connect() checks ESP8266::connect() return values and returns if unrecoverable errors are returned.
Pull request type
@VeijoPesonen , I modified the code to handle the errors recognized by ESP8266::connect() (AUTH_FAILURE, CONNECTION_TIMEOUT and NO_SSID). If any of these or OK are detected the ESP8266Interface::connect() will be signalled to return a proper return value.
I also updated the commit message and title of this PR, leaving the PR's Description as was, to maintain history.
I updated the code according to Veijo's remark (not to return if ESP advertises timeout). Unfortunately, the network-wifi-WIFI-CONNECT-SECURE-FAIL was not passing after this last change. I tried many things: the way we set up and tear down the test, the reset line assertion on disconnect, the order of tests in the suite, etc.