Skip to content

/mbed-os

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-coap to version 4.7.4 #9654

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Reviewers

@0xc0170 0xc0170

@yogpan01 yogpan01

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
5 participants
@anttiylitokola @ciarmcom @0xc0170 @mbed-ci @yogpan01
@anttiylitokola
Copy link
Contributor

anttiylitokola commented Feb 11, 2019

Description

  • Remove dependency to yotta tool
  • Do not remove stored (GET) blockwise message when EMPTY ACK received. When non piggybacked response mode is used original GET request must not be removed from the stored message list.Message is needed for building the next (GET) blockwise message.
  • Move definitions to sn_config.h

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yogpan01
@anttiylitokola
Update mbed-coap to version 4.7.4 
- Remove dependency to yotta tool
- Do not remove stored (GET) blockwise message when EMPTY ACK received. When non piggybacked response mode is used original GET request must not be removed from the stored message list.Message is needed for building the next (GET) blockwise message.
- Move definitions to sn_config.h
Loading status checks…
8073ce2

@ciarmcom ciarmcom requested review from yogpan01 and ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Sign in to view
Copy link
Member

ciarmcom commented Feb 11, 2019

@anttiylitokola, thank you for your changes.
@yogpan01 @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom added the needs: review label Feb 11, 2019

@0xc0170

0xc0170 approved these changes Feb 11, 2019
View changes

@0xc0170 0xc0170 added release-version: 5.11.5 needs: CI and removed needs: review labels Feb 11, 2019

@0xc0170

This comment has been minimized.

Sign in to view
Copy link
Member

0xc0170 commented Feb 11, 2019

CI started (while waiting for final approval)
@mbed-ci

This comment has been minimized.

Sign in to view
Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Feb 11, 2019

@yogpan01

yogpan01 approved these changes Feb 15, 2019
View changes

@yogpan01

This comment has been minimized.

Sign in to view
Copy link
Contributor

yogpan01 commented Feb 15, 2019

Looks good.Approved.

@0xc0170 0xc0170 added ready for merge and removed needs: review labels Feb 15, 2019

@0xc0170 0xc0170 merged commit a3500a3 into ARMmbed:master Feb 15, 2019
27 checks passed

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+12 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9294 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.