Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REALTEK_RTL8195AM binary timestamp #9658

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
7 participants
@alekla01
Copy link
Contributor

alekla01 commented Feb 11, 2019

MBEDOSTEST-458

Description

what: REALTEK_RTL8195AM test binary hash depends on build timestamp.
reason: https://github.com/ARMmbed/mbed-os/blob/master/tools/targets/REALTEK_RTL8195AM.py#L150
why does this matter: CI greentea-test skips binaries which have already passed. REALTEK_RTL8195AM test binary hashes are always different, which means CI cannot identify which binaries have already passed and which have not, thus all binaries for REALTEK_RTL8195AM are tested for (almost) every pull request for no reason.
solution: Keep binary hashes the same if dependencies have not been modified. Either remove the timestamp or enable timestamp redefining.

    build 1: •��IZ\    (�� J�mž !’ÑÊä¡…„	´q¿¦sÃ*�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFøµ5*ÿÿÿ
    build 2: •���\\    (�� J�mž !’ÑÊä¡…„	´q¿¦sÃ*�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFG.0øÿ

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-realtek

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 11, 2019

@alekla01, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 11, 2019

@alekla01, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@bridadan
Copy link
Contributor

bridadan left a comment

Seems fine to me

@0xc0170 0xc0170 requested a review from ARMmbed/team-realtek Feb 11, 2019

@tung7970

This comment has been minimized.

Copy link
Contributor

tung7970 commented Feb 11, 2019

Looks ok to me. If you can squash three commits into one, that will be easier to track.

@alekla01 alekla01 force-pushed the alekla01:patch-1 branch to 3e88cf7 Feb 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

@alekla01

build 1: •��IZ\ (�� J�mž !’ÑÊä¡…„ ´q¿¦sÃ�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFøµ5ÿÿÿ
build 2: •���\ (�� J�mž !’ÑÊä¡…„ ´q¿¦sÃ*�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFG.0øÿ

What is this ? I can't read it..

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

@alekla01 Doesn't this run the risk of not running tests when they need to?
How often is DAPLINK_TIMESTAMP updated?

@alekla01

This comment has been minimized.

Copy link
Contributor Author

alekla01 commented Feb 11, 2019

@0xc0170
What is this? *.bin diff.

@cmonr
Doesn't this run the risk of not running tests when they need to? No.
How often is `DAPLINK_TIMESTAMP` updated? It's not.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 12, 2019

@0xc0170 0xc0170 merged commit 26751ee into ARMmbed:master Feb 12, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9304 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.