Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: clean sensitive information from trace #9660

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
7 participants
@blind-owl
Copy link
Contributor

commented Feb 11, 2019

Description

Remove sensitive information from cellular subsystem trace logs.

  • SIM pin
  • APN username and password
    Test coverage:
  • unit tests. All pass
  • MTB_ADV_WISE_1570 ontarget gt tests, no regression.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte

@blind-owl blind-owl referenced this pull request Feb 11, 2019

Closed

Cellular clean logging #9536

@jarvte

jarvte approved these changes Feb 11, 2019

@ciarmcom ciarmcom requested review from jarvte and ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@blind-owl, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@blind-owl, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Feb 11, 2019


const bool stored_debug_state = _at->get_debug();
_at->set_debug(false);

_at->write_string(sim_pin);

This comment has been minimized.

Copy link
@cmonr

cmonr Feb 11, 2019

Contributor

Is there a reason that this line wasn't instead removed?

This comment has been minimized.

Copy link
@blind-owl

blind-owl Feb 12, 2019

Author Contributor

Not sure what you are referring here as injected code:

  1. stores current tracing state (enable/disable)
  2. disable tracing
  3. resumes stored tracing state after sim pin has been written to the modem (cellular subsystem)

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@blind-owl, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte

jarvte approved these changes Feb 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

LGTM but Cellular: clean sensitive information from trace commit should contain details from the description plus also why you are adding get_debug (was only set previously) - would answer my question

@0xc0170
Copy link
Member

left a comment

^^

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

I set it to 5.11.5 but we might just have conflicts with latest refactor so some patches might need manual resolution for 5.11.x or just moving to 5.12.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

Moving to 5.12.

Confirmed that trying to bring this into a patch would lead to pain for @adbridge 😁

Cellular: clean sensitive information from trace
Information removed from the cellular subsystem trace log:
* SIM pin
* APN username and password

Added get_debug() to ATHandler.h to get the current trace state in order
to support suspend/resume of trace output.

@blind-owl blind-owl force-pushed the blind-owl:clean_cellular_trace branch to b6a0892 Feb 14, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 15, 2019

@cmonr cmonr merged commit 7f24897 into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/build-ARMC6 Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/cloud-client-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/exporter Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/greentea-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/mbed2-build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/mbed2-build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/mbed2-build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9660/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9243 cycles (+200 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

@blind-owl blind-owl deleted the blind-owl:clean_cellular_trace branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.