Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btle: fix build warning about unused clockConfiguration #9691

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
7 participants
@naveenkaje
Copy link
Contributor

naveenkaje commented Feb 12, 2019

Description

Fix the following build warning seen with both GCC and ARM_CC (built with mbed-cli v1.8.3)

[Warning] btle.cpp@115,0:  #177-D: variable "clockConfiguration"  was declared but never referenced

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Feb 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Feb 12, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 13, 2019

@cmonr @0xc0170 do we need to wait for a review from mbed-os-pan on this one?

@0xc0170
Copy link
Member

0xc0170 left a comment

100644 → 100755

Please fix the file attributes

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Feb 13, 2019

@pan-

pan- approved these changes Feb 13, 2019

Copy link
Member

pan- left a comment

Why the change of permissions ? 100644 → 10075

btle: fix build warning about unused clockConfiguration
Fix the following build warning seen with both GCC and ARM_CC
[Warning] btle.cpp@115,0:  #177-D: variable "clockConfiguration"  was declared but never referenced

@naveenkaje naveenkaje force-pushed the naveenkaje:fix_btle_clockconfig_warning branch to 0563276 Feb 13, 2019

@naveenkaje

This comment has been minimized.

Copy link
Contributor Author

naveenkaje commented Feb 13, 2019

Why the change of permissions ? 100644 → 10075

Thanks for catching this. I found out that my editor was secretly changing the permissions under cover. I have fixed it now.

Attribute updated

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 14, 2019

@cmonr cmonr merged commit d36ebe7 into ARMmbed:master Feb 14, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10045 cycles (+700 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.