Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanostack: icmpv6: fix build warning #9694

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
5 participants
@naveenkaje
Copy link
Contributor

naveenkaje commented Feb 12, 2019

Description

Fix the following build warning seen when building with GCC

Compile [ 54.2%]: icmpv6.c
[Warning] icmpv6.c@1091,16: this statement may fall through [-Wimplicit-fallthrough=]

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 13, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-mesh Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 13, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

CI started while waiting on Mesh Team.

Not too conmfortable simply ignoring a warning, but if only GCC is complainging, it can't be that bad?

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 13, 2019

Test run: FAILED

Summary: 2 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@0xc0170
Copy link
Member

0xc0170 left a comment

100644 → 100755

Fix file attributes.

attribute ((fallthrough));

Failing few builds, is this available in all our toolchains?

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Feb 13, 2019

@naveenkaje naveenkaje force-pushed the naveenkaje:fix_icmpv6_warning branch Feb 13, 2019

nanostack: icmpv6: fix build warning
Fix the following build warning seen when building with GCC

Compile [ 54.2%]: icmpv6.c
[Warning] icmpv6.c@1091,16: this statement may fall through [-Wimplicit-fallthrough=]

@naveenkaje naveenkaje force-pushed the naveenkaje:fix_icmpv6_warning branch to 8d0c94e Feb 13, 2019

@naveenkaje

This comment has been minimized.

Copy link
Contributor Author

naveenkaje commented Feb 13, 2019

100644 → 100755

Fix file attributes.

attribute ((fallthrough));

Failing few builds, is this available in all our toolchains?

I see

[Warning] icmpv6.c@1087,0:  #1207-D: unknown attribute "fallthrough"
[Warning] icmpv6.c@1096,0:  #1207-D: unknown attribute "fallthrough"

With ARMCC. Perhaps it is only for GCC.

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html indicates that this is standardized now. I changed my patch and tested with ARMCC and GCC. I see no warnings locally. Lets see if this is ok for all supported toolchains in our CI.

@cmonr cmonr added needs: CI and removed needs: work labels Feb 13, 2019

Attribute updated.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 14, 2019

@cmonr cmonr merged commit 9be82d9 into ARMmbed:master Feb 14, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9780 cycles (+435 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.