Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netsocket documentation cleanup #9698

Merged

Conversation

Projects
None yet
7 participants
@michalpasztamobica
Copy link
Contributor

commented Feb 13, 2019

Description

Applying review remarks from PR #9630.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnotherButler
@SeppoTakalo

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-test Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@SeppoTakalo
Copy link
Contributor

left a comment

Looks good, just a small changes requested.

Show resolved Hide resolved TESTS/netsocket/README.md Outdated
Show resolved Hide resolved TESTS/netsocket/README.md Outdated
Show resolved Hide resolved TESTS/netsocket/README.md Outdated
Show resolved Hide resolved TESTS/netsocket/README.md Outdated
Show resolved Hide resolved TESTS/netsocket/README.md Outdated

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:netsocket_documentation_cleanup branch Feb 13, 2019

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@SeppoTakalo , thanks for the review. I updated according to your remarks + fixed some more errors such as non-capital letters starting sentences.

@cmonr

cmonr approved these changes Feb 13, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

@michalpasztamobica this appears to need a rebase now, please take a look.

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:netsocket_documentation_cleanup branch to 5eaf08e Feb 18, 2019

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Rebase done.
@AnotherButler , please, approve if these changes are all OK now.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 18, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

CI started whilst final review comes in

@cmonr cmonr added ready for merge and removed needs: review labels Feb 19, 2019

@cmonr cmonr merged commit b59b817 into ARMmbed:master Feb 19, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9382 cycles (-1099 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.