Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fix onboard modems powering failure. #9706

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
6 participants
@jarvte
Copy link
Contributor

commented Feb 13, 2019

Description

Fix onboard modem power up failures.

  • don't call soft power on if device was already powered
  • some modems need to wait before sending anything to modem after soft powering

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@@ -19,7 +19,7 @@
#include "cellular/onboard_modem_api.h"
#include "UARTSerial.h"
#include "ONBOARD_TELIT_HE910.h"
#include "CellularLog.h"
#include "ThisThread.h"

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Feb 13, 2019

Contributor

tr_debug may need CellularLog, if not coming from other includes..?

This comment has been minimized.

Copy link
@cmonr

cmonr Feb 13, 2019

Contributor

Once this is resolved, will start CI

This comment has been minimized.

Copy link
@jarvte

jarvte Feb 14, 2019

Author Contributor

Added Cellularlog to both targets.

@cmonr

cmonr approved these changes Feb 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

  • don't call soft power on if device was already powered
  • some modems need to wait before sending anything to modem after soft powering

Why aren't this captured in the commit msg?

Cellular: fix onboard modems powering failure
Don't call soft power on if device was already powered.
Some modems need to wait before sending anything to modem after soft powering.

@jarvte jarvte force-pushed the jarvte:fix_powering_onboard_modems branch to e4018bd Feb 14, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

  • don't call soft power on if device was already powered
  • some modems need to wait before sending anything to modem after soft powering

Why aren't this captured in the commit msg?

Updated commit msg.

@cmonr cmonr added needs: CI and removed needs: work labels Feb 14, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 15, 2019

@cmonr cmonr merged commit 67abaf5 into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10457 cycles (+1414 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

@jarvte jarvte deleted the jarvte:fix_powering_onboard_modems branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.