-
Notifications
You must be signed in to change notification settings - Fork 3k
Tools: Reoder post-build hooks and bl merging #9738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
tools/toolchains/__init__.py
Outdated
# Initialize memap and process map file. This doesn't generate output. | ||
self.mem_stats(mapfile) | ||
|
||
self.notify.var("compile_succeded", True) | ||
self.notify.var("binary", filename) | ||
|
||
return full_path, needed_update | ||
return full_path, updatable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop needed_update
completely then? Doesn't seem to be used in this function.
Also, I can't find a call in our code base that actually uses the updatable
result from link_program()
. Is it possible to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We can remove that too. We may have to update the online compiler to use this new API.
@bridadan Ready for review again, supposing that travis passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
@ARMmbed/mbed-os-storage Please review. |
Still waiting on a review by @ARMmbed/mbed-os-storage @bulislaw Fyi |
@theotherjimmy And now this needs a rebase. |
105224d
to
bedfcff
Compare
@cmonr Rebase done. |
CI started assuming @ARMmbed/mbed-os-storage will eventually_ be ok with this PR. |
Test run: FAILEDSummary: 3 of 8 test jobs failed Failed test jobs:
|
This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please make necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection. |
This PR looks fine for me. @theotherjimmy, I have only one question. The changes here originated from the need to compile and build FUTURE_SEQUANA_PSA with bootloader support. in order to do so @bridadan helped us with some tweaks and changes. are all those changes included in the PR or they are not needed here? |
@bulislaw please be aware that this PR is related to PSA, and we may need additional changes when the platforms code will be available |
Errors seem to be CI passing in unsupported platforms. |
@dannybenor You may need additional PRs. This change is complete as is, so long as no bugs are found around the reordering. Please don't hold PRs because you might find that you need changes related to them. |
@yossi2le You're going to have to remind me what those changes are. They probably should come in as other PRs though. |
bedfcff
to
b5e79b2
Compare
@dannybenor Which is when? We're running out of days before code freeze... |
@theotherjimmy This needs a rebase. |
b5e79b2
to
b7e0102
Compare
@cmonr rebase done |
Aparantely I missed this previously
The 4 remaining are related to the fact that __init__.py defines a base class. They'll be removed next commit
except for the extremely long regex
2eea5cc
to
c9b613c
Compare
Ci started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
CI job restarted: Job config was updated to properly run against list of targets instead of an empty list. |
Hmmm.... Trying a complete rebuild. Suspect that the export fix that was recently applied didn't quite do the job. |
CI restarted |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
CI restarted. |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
exporters green 👍 |
Description
On current master, post-build hooks are run before any merging that
managed bootloader mode would do. This puts several targets in a hard
place: they need the post-build hook to run to complute a digest of
the ROM, but when using managed bl mode, these digests are incorrect.
This PR reorders the post-build hooks to run after the merging of
managed bootloader mode, and on the "Image" (as opposed to the
"Update Image"). This should allow post build hooks that generate a
digest of the ROM to compute a correct digest.
Pull request type
Reviewers
@bridadan, For tools changes
@ARMmbed/mbed-os-storage , This team raised the issue