Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect return value in psa_security_lifecycle_state (emul) #9745

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
7 participants
@moranpeker
Copy link
Contributor

commented Feb 17, 2019

Description

psa_security_lifecycle_state should return uint32_t of the security
lifecycle state.

bug: psa_platfrom_lifecycle_get_impl return value is psa_status_t.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@alzix

Release Notes

Moran Peker
Fix incorrect return value in psa_security_lifecycle_state (emul)
psa_security_lifecycle_state should return uint32_t of the security
lifecycle state.
bug: psa_platfrom_lifecycle_get_impl return value
is psa_status_t.
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

@moranpeker, thank you for your changes.
@alzix @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from alzix and ARMmbed/mbed-os-maintainers Feb 17, 2019

@alzix
Copy link
Contributor

left a comment

This code was written before #9708.
I suggest to rebase on top of it and use PSA_SUCCESS instead of PSA_LIFECYCLE_SUCCESS. In addition I would suggest verifying that PSA_LIFECYCLE_UNKNOWN does not collide with one of predefined PSA error codes.

@alzix

alzix approved these changes Feb 20, 2019

Copy link
Contributor

left a comment

LGTM

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

CI started

moranpeker pushed a commit to moranpeker/mbed-os that referenced this pull request Feb 20, 2019

Moran Peker
Get security lifecycle by psa_security_lifecycle_state function
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745
-Remove lifecycle data from temp boot status data
-Update attesttation_partition_json file to use
PSA_PLATFORM_LC_GET and generate partition
code - auto generated files update
@mbed-ci

This comment has been minimized.

Copy link

commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@moranpeker If you see CI started and you push a new update ,please leave a comment. I'll restart testing

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

@0xc0170 I don't think a commit was added.

that referenced this pull request

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 20, 2019

@cmonr cmonr merged commit 813c844 into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10123 cycles (-358 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 20, 2019

netanelgonen pushed a commit to kfnta/mbed-os that referenced this pull request Feb 24, 2019

Moran Peker Netanel Gonen
Get security lifecycle by psa_security_lifecycle_state function
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745
-Remove lifecycle data from temp boot status data
-Update attesttation_partition_json file to use
PSA_PLATFORM_LC_GET and generate partition
code - auto generated files update

netanelgonen pushed a commit to kfnta/mbed-os that referenced this pull request Feb 25, 2019

Moran Peker Netanel Gonen
Get security lifecycle by psa_security_lifecycle_state function
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745
-Remove lifecycle data from temp boot status data
-Update attesttation_partition_json file to use
PSA_PLATFORM_LC_GET and generate partition
code - auto generated files update

moranpeker pushed a commit to moranpeker/mbed-os that referenced this pull request Feb 27, 2019

Moran Peker
Get security lifecycle by psa_security_lifecycle_state function
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745
-Remove lifecycle data from temp boot status data
-Update attesttation_partition_json file to use
PSA_PLATFORM_LC_GET and generate partition
code - auto generated files update

netanelgonen pushed a commit to kfnta/mbed-os that referenced this pull request Feb 28, 2019

Moran Peker Netanel Gonen
Get security lifecycle by psa_security_lifecycle_state function
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745
-Remove lifecycle data from temp boot status data
-Update attesttation_partition_json file to use
PSA_PLATFORM_LC_GET and generate partition
code - auto generated files update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.