Fix incorrect return value in psa_security_lifecycle_state (emul) #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psa_security_lifecycle_state should return uint32_t of the security lifecycle state. bug: psa_platfrom_lifecycle_get_impl return value is psa_status_t.
|
@moranpeker, thank you for your changes. |
alzix
suggested changes
Feb 17, 2019
There was a problem hiding this comment.
This code was written before #9708.
I suggest to rebase on top of it and use PSA_SUCCESS instead of PSA_LIFECYCLE_SUCCESS. In addition I would suggest verifying that PSA_LIFECYCLE_UNKNOWN does not collide with one of predefined PSA error codes.
0xc0170
approved these changes
Feb 20, 2019
|
CI started |
moranpeker
pushed a commit
to moranpeker/mbed-os
that referenced
this pull request
Feb 20, 2019
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745 -Remove lifecycle data from temp boot status data -Update attesttation_partition_json file to use PSA_PLATFORM_LC_GET and generate partition code - auto generated files update
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
|
@moranpeker If you see CI started and you push a new update ,please leave a comment. I'll restart testing |
|
@0xc0170 I don't think a commit was added.
|
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
moranpeker
pushed a commit
to moranpeker/mbed-os
that referenced
this pull request
Feb 27, 2019
-Add bug fix for psa_security_lifecycle_state function - PR ARMmbed#9745 -Remove lifecycle data from temp boot status data -Update attesttation_partition_json file to use PSA_PLATFORM_LC_GET and generate partition code - auto generated files update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
psa_security_lifecycle_state should return uint32_t of the security
lifecycle state.
bug: psa_platfrom_lifecycle_get_impl return value is psa_status_t.
Pull request type
Reviewers
@alzix
Release Notes