Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSOC6: update the psoc6pdl and HAL to the latest version #9762

Merged
merged 4 commits into from Feb 20, 2019

Conversation

Projects
None yet
6 participants
@vmedcy
Copy link
Contributor

vmedcy commented Feb 19, 2019

Description

This PR brings numerous updates to the Cypress targets for Mbed OS 5.11.5:

  • Update psoc6pdl to the latest version delivered as part of PSoC 6 SDK with ModusToolbox 1.1
  • Minor updates to the Cypress PSoC 6 HAL and CYW43XXX HCIDriver (internal code review + astyle run)
  • Update BSP generated sources using the latest version of PSoC 6 MCU Device Configurator
  • Switch all BSPs to use WCO clock as LFCLK clock source.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

vmedcy added some commits Feb 15, 2019

PSOC6: update BSP generated sources with latest configurator
Use ModusToolbox Device Configurator 1.1.0.284 to generate the
BSP low-level initialization code. Compatible version of Device
Configurator to be released with ModusToolbox 1.1.

Notable changes:
* rename cycfg_connectivity -> cycfg_routing
* switch LF_CLK clock source from ILO to WCO on
  CY8CPROTO-062-4343W and CYW943012P6EVB-01

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 19, 2019

@vmedcy, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

CI started while this undergoes reviews.

Lots of small changes, but curious to see what CI says in the meanwhile

@cmonr

cmonr approved these changes Feb 19, 2019

Copy link
Contributor

cmonr left a comment

Thank you for splitting and commenting the PRs.
Makes reviews go by with much less pain.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

@ARMmbed/mbed-os-pan I believe y'all only need to review cefc745

@ARMmbed/mbed-os-crypto I'm unsure if you review partner crypto implementaions, but if so please take a look at edb944a

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@yanesca

This comment has been minimized.

Copy link
Contributor

yanesca commented Feb 20, 2019

@cmonr We focus on the integration code with Mbed TLS and don't review partner crypto code. However, while reviewing the integration code we usually need to have a superficial look on the driver code. I can't see any integration code in this commit and I don't think we need to review it.

@0xc0170 0xc0170 merged commit 2d30d0f into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10455 cycles (+57 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 20, 2019

@yanesca Thanks for that clarification. Will keep it in mind moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.