Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing wifi parameters to test configs #9778

Merged

Conversation

Projects
None yet
7 participants
@michalpasztamobica
Copy link
Contributor

commented Feb 20, 2019

Description

The point is to follow the configs as described in the documentation .

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

Show resolved Hide resolved tools/test_configs/HeapBlockDeviceAndWifiInterface.json Outdated

@ciarmcom ciarmcom requested review from SeppoTakalo and ARMmbed/mbed-os-maintainers Feb 20, 2019

@ciarmcom

This comment has been minimized.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

@michalpasztamobica What happens if WIFI_MAX_SCAN_SIZE is undefined? Wouldn't the json then be invalid?

@bridadan
Copy link
Contributor

left a comment

My feedback echos @SeppoTakalo

@cmonr cmonr added needs: work and removed needs: review labels Feb 20, 2019

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:add_missing_wifi_config_params branch Feb 21, 2019

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

@cmonr , @SeppoTakalo , you are right, I might have overinterpreted my task... PR amended to reflect your input, thanks for that.
@SeppoTakalo, before approving, please take a look into internal JIRA ticket ONME-4147 - it seems the task's goals have changed, but let's make sure we can close that JIRA with this PR...

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Noticed some missing network parameters documentation, so added that in a separate commit, but I think it's related enough to merge both in one PR.

@bridadan
Copy link
Contributor

left a comment

Thanks for the changes. The configuration values are up to the folks who maintain those, so if it works for you it works for me.

@cmonr cmonr added needs: review and removed needs: work labels Feb 21, 2019

Show resolved Hide resolved tools/test_configs/ESP8266Interface.json Outdated
Show resolved Hide resolved tools/test_configs/HeapBlockDeviceAndWifiInterface.json Outdated
Show resolved Hide resolved tools/test_configs/SpwfSAInterface.json Outdated

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:add_missing_wifi_config_params branch to 08b06e2 Feb 22, 2019

@@ -26,7 +62,7 @@
"target.network-default-interface-type": "WIFI",
"nsapi.default-wifi-ssid": "\"WIFI_SSID\"",
"nsapi.default-wifi-password": "\"WIFI_PASSWORD\"",
"nsapi.default-wifi-security": "WIFI_SECURITY",
"nsapi.default-wifi-security": "WPA2",

This comment has been minimized.

Copy link
@michalpasztamobica

michalpasztamobica Feb 22, 2019

Author Contributor

To keep thos configs compileable out of the box I had to change this setting.
Otherwise we get:

[Error] NetworkInterfaceDefaults.cpp@86,0:  #20: identifier "NSAPI_SECURITY_WIFI_SECURITY" is undefined
@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

@VeijoPesonen , thanks for your feedback. I just pushed a commit with "Wi-Fi" written correctly :)

@cmonr

cmonr approved these changes Feb 25, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

The point is to follow the configs as described in the documentation .

🎉

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

CI started

@cmonr cmonr added the risk: G label Feb 25, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 25, 2019

@cmonr cmonr merged commit 044d0c9 into ARMmbed:master Feb 25, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10119 cycles (-388 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.