BLE: Cordio build time configuration through mbed_lib.json #9813

paul-szczepanek-arm · 2019-02-22T11:40:13Z

Description

This doesn't change anything but provides an easy to find entry point to configure the Cordio stack.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-
@donatieng

Release Notes

This doesn't remove the old Cordio stack config file and merely sits on top so will not introduce any unexpected changes. In case users modified the cfg files themselves (in features\FEATURE_BLE\targets\TARGET_CORDIO\stack\cordio_stack\ble-host\sources\stack\cfg) they will have to resolve the conflict.

ciarmcom · 2019-02-22T12:00:30Z

@paul-szczepanek-arm, thank you for your changes.
@donatieng @pan- @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

pan-

For maintenance wouldn't it make more sense to export config with names equal to the one used in cfg_stack.h. I would avoid modification of cfg_stack.h

pan- · 2019-02-25T09:04:57Z

@0xc0170 we need the 5.12 tag.

0xc0170 · 2019-02-25T09:09:11Z

features/FEATURE_BLE/targets/TARGET_CORDIO/mbed_lib.json

+        "cordio-cfg-max-connections": {
+            "help": "Maximum number of connections",
+            "value": 3,
+            "macro_name": "CORDIO_CFG_MAX_CONNECTIONS"


My assumption is using macro_name to overwrite the default one - length ? Or why?

paul-szczepanek-arm · 2019-02-25T09:49:52Z

OK, I think this implements both of your comments.

0xc0170 · 2019-02-25T11:11:48Z

CI started

mbed-ci · 2019-02-25T14:52:42Z

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

pan- · 2019-02-25T15:19:49Z

13:24:26 13:24:26 [CY8CKIT_062_4343W:IAR] [examples] Running shell script
13:24:26 13:24:26 [CY8CKIT_062_4343W:IAR] + python -u ../mbed-os/tools/test/examples/examples.py compile IAR --mcu CY8CKIT_062_4343W
[Pipeline] [CY8CKIT_062_WIFI_BT:IAR] }
[Pipeline] [CY8CKIT_062_WIFI_BT:IAR] // dir
[Pipeline] [CY8CKIT_062_WIFI_BT:IAR] echo
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Failed in examples compile hudson.AbortException: script returned exit code 1

That is not a helpful message.
@paul-szczepanek-arm could you check the command that failed ?

Edit: the log is issued latter actually:

13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] [examples] Running shell script
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] + tail -n 100 mbed-os_examples_compile_CY8CKIT_062_WIFI_BT_IAR.log
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] 
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Compiling example repos....
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] 
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Compiling mbed-os-example-blinky for CY8CKIT_062_WIFI_BT, IAR
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] [mbed] WARNING: Could not find mbed program in current path "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky".
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        You can fix this by calling "mbed new ." in the root of your program.
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] ---
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] [mbed] WARNING: Missing Python modules were not auto-installed.
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        The Mbed OS tools in this program require the following Python modules: colorama, urllib3, prettytable, junit_xml, pyyaml, jsonschema, future, six, mbed_cloud_sdk, requests, idna, pyserial, jinja2, intelhex, intervaltree, mbed_ls, mbed_host_tests, mbed_greentea, beautifulsoup4, fuzzywuzzy, pyelftools, manifest_tool, icetea, pycryptodome
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        You can install all missing modules by running "pip install -r requirements.txt" in "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os"
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        On Posix systems (Linux, etc) you might have to switch to superuser account or use "sudo"
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] ---
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Building project mbed-os-example-blinky (CY8CKIT_062_WIFI_BT, IAR)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Scan: mbed-os-example-blinky
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Error parsing './mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/mbed_lib.json': Expecting property name enclosed in double quotes: line 52 column 9 (char 1912)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] Traceback (most recent call last):
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]   File "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/make.py", line 74, in wrapped_build_project
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]     src_dir, build_dir, mcu, *args, **kwargs
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]   File "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/build_api.py", line 545, in build_project
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]     src_paths, toolchain, inc_dirs=inc_dirs)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]   File "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/resources/__init__.py", line 569, in scan_with_toolchain
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]     toolchain.config.load_resources(self)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]   File "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/config/__init__.py", line 1292, in load_resources
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]     f.path for f in resources.get_file_refs(FileType.JSON)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]   File "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/config/__init__.py", line 553, in add_config_files
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]     raise ConfigException(str(exc))
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] ConfigException: Expecting property name enclosed in double quotes: line 52 column 9 (char 1912)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] [mbed] ERROR: "/builds/ws/mbed-os-ci_build-IAR/pyenv/bin/python" returned error.
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        Code: 1
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        Path: "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky"
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        Command: "/builds/ws/mbed-os-ci_build-IAR/pyenv/bin/python -u /builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/make.py -t IAR -m CY8CKIT_062_WIFI_BT --source . --build ./BUILD/CY8CKIT_062_WIFI_BT/IAR -v"
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR]        Tip: You could retry the last command with "-v" flag for verbose output
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] ---
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] [mbed] Working path "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky" (directory)
13:24:27 13:24:27 [CY8CKIT_062_WIFI_BT:IAR] [mbed] Exec "/builds/ws/mbed-os-ci_build-IAR/pyenv/bin/python -u /builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky/mbed-os/tools/make.py -t IAR -m CY8CKIT_062_WIFI_BT --source . --build ./BUILD/CY8CKIT_062_WIFI_BT/IAR -v" in "/builds/ws/mbed-os-ci_build-IAR/examples/mbed-os-example-blinky"

pan- · 2019-02-25T15:24:40Z

features/FEATURE_BLE/targets/TARGET_CORDIO/mbed_lib.json

+        },
+        "desired-att-mtu": {
+            "help": "Desired ATT_MTU, this needs to be between 23 and 517 (inclusive).",
+            "value": 23,


Suggested change

"value": 23,

"value": 23

pan- · 2019-02-25T15:24:53Z

features/FEATURE_BLE/targets/TARGET_CORDIO/mbed_lib.json

+        },
+        "max-prepared-writes": {
+            "help": "Number of queued prepare writes supported by server.",
+            "value": 4,


Suggested change

"value": 4,

"value": 4

adbridge · 2019-02-25T15:27:49Z

ci restarted

paul-szczepanek-arm · 2019-02-25T15:28:06Z

I'd wait! you guys are just too fast for me

adbridge · 2019-02-25T15:30:19Z

OK i have killed the job! @paul-szczepanek-arm please let us know when it is ready

paul-szczepanek-arm · 2019-02-25T15:34:48Z

Apologies, it's good to go.

cmonr · 2019-02-25T17:20:35Z

Will wait on Travis CI to complete before restarting.

cmonr · 2019-02-25T17:49:04Z

CI started

mbed-ci · 2019-02-25T22:43:58Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

danger4386 · 2020-07-06T15:17:14Z

Is it possible to configure this value in a custom_targets.json file?

danger4386 · 2020-07-06T16:27:14Z

You can configure this parameter similar to others using the mbed_app.json:

{
"target_overrides": {
"*": {
"cordio.desired-att-mtu": 66,
"cordio.rx-acl-buffer-size": 70
}
}
}

paul-szczepanek-arm added 2 commits February 22, 2019 11:28

put cordio cfg in mbed_lib.json

8654644

mention config in readme

4470f64

paul-szczepanek-arm changed the title ~~Cordio cfg~~ BLE: Cordio build time configuration through mbed_lib.json Feb 22, 2019

ciarmcom requested review from donatieng, pan- and a team February 22, 2019 12:00

ciarmcom added the needs: review label Feb 22, 2019

prepared writes options

4b0296a

pan- reviewed Feb 25, 2019

View reviewed changes

0xc0170 added the release-version: 5.12.0-rc1 label Feb 25, 2019

0xc0170 reviewed Feb 25, 2019

View reviewed changes

use existing macro names

6a2b6b8

revert macros

6842c87

pan- approved these changes Feb 25, 2019

View reviewed changes

0xc0170 approved these changes Feb 25, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Feb 25, 2019

stray comma

e75c534

0xc0170 added needs: work and removed needs: CI labels Feb 25, 2019

pan- reviewed Feb 25, 2019

View reviewed changes

0xc0170 added the needs: CI label Feb 25, 2019

0xc0170 removed the needs: work label Feb 25, 2019

fixed names

a729718

adbridge added needs: work and removed needs: CI labels Feb 25, 2019

typos

f62217b

cmonr added needs: CI and removed needs: work labels Feb 25, 2019

cmonr added the risk: G label Feb 25, 2019

cmonr added ready for merge and removed needs: CI labels Feb 25, 2019

cmonr merged commit d0881ad into ARMmbed:master Feb 25, 2019

cmonr removed the ready for merge label Feb 25, 2019

donatieng mentioned this pull request Mar 1, 2019

CordioBLE stack MTU size configuration #9733

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BLE: Cordio build time configuration through mbed_lib.json #9813

BLE: Cordio build time configuration through mbed_lib.json #9813

paul-szczepanek-arm commented Feb 22, 2019

ciarmcom commented Feb 22, 2019

pan- left a comment

pan- commented Feb 25, 2019

0xc0170 Feb 25, 2019

paul-szczepanek-arm commented Feb 25, 2019

0xc0170 commented Feb 25, 2019

mbed-ci commented Feb 25, 2019

pan- commented Feb 25, 2019 •

edited

pan- Feb 25, 2019

pan- Feb 25, 2019

adbridge commented Feb 25, 2019

paul-szczepanek-arm commented Feb 25, 2019 •

edited

adbridge commented Feb 25, 2019

paul-szczepanek-arm commented Feb 25, 2019

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

mbed-ci commented Feb 25, 2019

danger4386 commented Jul 6, 2020

danger4386 commented Jul 6, 2020

BLE: Cordio build time configuration through mbed_lib.json #9813

BLE: Cordio build time configuration through mbed_lib.json #9813

Conversation

paul-szczepanek-arm commented Feb 22, 2019

Description

Pull request type

Reviewers

Release Notes

ciarmcom commented Feb 22, 2019

pan- left a comment

Choose a reason for hiding this comment

pan- commented Feb 25, 2019

0xc0170 Feb 25, 2019

Choose a reason for hiding this comment

paul-szczepanek-arm commented Feb 25, 2019

0xc0170 commented Feb 25, 2019

mbed-ci commented Feb 25, 2019

Test run: FAILED

pan- commented Feb 25, 2019 • edited

pan- Feb 25, 2019

Choose a reason for hiding this comment

pan- Feb 25, 2019

Choose a reason for hiding this comment

adbridge commented Feb 25, 2019

paul-szczepanek-arm commented Feb 25, 2019 • edited

adbridge commented Feb 25, 2019

paul-szczepanek-arm commented Feb 25, 2019

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

mbed-ci commented Feb 25, 2019

Test run: SUCCESS

danger4386 commented Jul 6, 2020

danger4386 commented Jul 6, 2020

pan- commented Feb 25, 2019 •

edited

paul-szczepanek-arm commented Feb 25, 2019 •

edited