Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply artifact_name configuration parameter to exported projects #9817

Merged
merged 4 commits into from Mar 1, 2019

Conversation

Projects
None yet
7 participants
@kegilbert
Copy link
Contributor

commented Feb 22, 2019

Description

#8428

Previously the artifact_name parameter was not used when exporting projects. I just slipped this little guy in as it should cover all use cases, let me know if I missed something though as I'm a bit less familiar with this section of the tools!

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy
@bridadan

Release Notes

@kegilbert kegilbert force-pushed the kegilbert:artifact_name_export branch to 056b88a Feb 22, 2019

@theotherjimmy
Copy link
Contributor

left a comment

There's a property that does this in the config class. That way we don't have to use this constant in multiple places.

Show resolved Hide resolved tools/export/__init__.py Outdated
Show resolved Hide resolved tools/export/__init__.py Outdated

@NirSonnenschein NirSonnenschein requested review from ARMmbed/mbed-os-tools Feb 25, 2019

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 25, 2019

theotherjimmy and others added some commits Feb 25, 2019

Update tools/export/__init__.py
Co-Authored-By: kegilbert <K.Gilbert.CH@gmail.com>
Update tools/export/__init__.py
Co-Authored-By: kegilbert <K.Gilbert.CH@gmail.com>

@cmonr cmonr requested a review from theotherjimmy Feb 25, 2019

@cmonr

cmonr approved these changes Feb 25, 2019

Show resolved Hide resolved tools/export/__init__.py Outdated
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

CI started

Update tools/export/__init__.py
Co-Authored-By: kegilbert <K.Gilbert.CH@gmail.com>
@cmonr

cmonr approved these changes Feb 26, 2019

Suggestions used. Please re-review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 26, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

This will need restarting CI

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 27, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Info: A CI config issue appears to be affecting NUMAKER_PFM_M2351 builds. Please ignore build errors against the target for now.

Other build failures should still be investigated, if any. Will restart CI when appropriate.

@cmonr cmonr added the risk: A label Feb 28, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC6
  • jenkins-ci/mbed-os-ci_build-ARMC6
@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC5
@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

We are testing the CI fix (the last 2 failures) another run in CI now

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Restarted CI & Restarted greentea-test.

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

Fyi, jenkins-ci/mbed-os-ci_greentea-test was restarted and passed.

@cmonr cmonr merged commit 460e4e7 into ARMmbed:master Mar 1, 2019

30 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9180 cycles (-468 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.