Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: astyle fixes #9893

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
7 participants
@VeijoPesonen
Copy link
Contributor

commented Feb 28, 2019

Description

astyle fixes

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica

Release Notes

@ciarmcom ciarmcom requested review from michalpasztamobica and ARMmbed/mbed-os-maintainers Feb 28, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@cmonr

cmonr approved these changes Feb 28, 2019

Show resolved Hide resolved .astyleignore

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:wifi_astyle_unignore branch Mar 1, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@cmonr rebased.

@0xc0170

0xc0170 approved these changes Mar 1, 2019

Copy link
Member

left a comment

+1 for less astyle ignore files

@michalpasztamobica
Copy link
Contributor

left a comment

Travis seems to complain about one more astyle issue, but this is generally all good :)

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:wifi_astyle_unignore branch to c9eaa07 Mar 4, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Check, and then check again... Fixed, please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 13, 2019

@0xc0170 0xc0170 merged commit 17f8bc1 into ARMmbed:master Mar 14, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9202 cycles (-1281 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:wifi_astyle_unignore branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.