Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: check if recv returned too much data #9905

Merged

Conversation

Projects
None yet
7 participants
@michalpasztamobica
Copy link
Contributor

commented Mar 1, 2019

Description

There are devices which happen to return more data than it was requested when TCPSocket::recv() is called. We need to add checks against this.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@juhoeskeli
@pekkapesu
@SeppoTakalo
@VeijoPesonen

Release Notes

@ciarmcom ciarmcom requested review from juhoeskeli, pekkapesu, SeppoTakalo, VeijoPesonen and ARMmbed/mbed-os-maintainers Mar 1, 2019

@ciarmcom

This comment has been minimized.

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@juhoeskeli , @pekkapesu , would you let us know which platforms exactly were the ones causing issues? Perhaps we could run the PR on those targets as the devices we have available don't really trigger these errors.

Show resolved Hide resolved TESTS/netsocket/tcp/tcpsocket_echotest_burst.cpp Outdated
Show resolved Hide resolved TESTS/netsocket/tls/tlssocket_echotest_burst.cpp Outdated
@VeijoPesonen
Copy link
Contributor

left a comment

Please see my earlier comments.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 1, 2019

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:test_recv_return_less_or_equal branch Mar 1, 2019

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:test_recv_return_less_or_equal branch to c81f71b Mar 1, 2019

@cmonr

cmonr approved these changes Mar 5, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 15, 2019

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

io serial, restarting test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 15, 2019

@0xc0170 0xc0170 merged commit 91b81c6 into ARMmbed:master Mar 15, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-52 bytes)
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9179 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.