Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA tools docs #9963

Merged
merged 4 commits into from Mar 7, 2019

Conversation

Projects
None yet
7 participants
@orenc17
Copy link
Contributor

commented Mar 6, 2019

Description

Create documentation for all the PSA python tools & scripts.

This PR depends on:

Do not run CI untill all of the above are merged

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikisch81 @ARMmbed/mbed-os-maintainers

Release Notes

@orenc17 orenc17 force-pushed the kfnta:psa_tools_docs branch to b2c1fe0 Mar 6, 2019

@ciarmcom ciarmcom requested review from mikisch81 and ARMmbed/mbed-os-maintainers Mar 6, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@orenc17, thank you for your changes.
@mikisch81 @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.


`release.py` is the script assigned with compiling the secure images.

```python

This comment has been minimized.

Copy link
@theotherjimmy

theotherjimmy Mar 6, 2019

Contributor

I don't think this code block contains python

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 6, 2019

Author Contributor

thanks, removed that

@cmonr cmonr requested a review from AnotherButler Mar 6, 2019

each implementation requires a set of auto generated files describing the secure partitions.

* `generate_partition_code.py` - Generate files for both implementations.
* `generate_mbed_spm_partition_code.py` - Generate files for BMED_SPM.

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 6, 2019

Contributor

I'd like to know what BMED_SPM is 😁

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 6, 2019

Author Contributor

2vecn2

each implementation requires a set of auto generated files describing the secure partitions.

* `generate_partition_code.py` - Generate files for both implementations.
* `generate_mbed_spm_partition_code.py` - Generate files for BMED_SPM.

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 6, 2019

Contributor

A question about the script name.

Is there a reason it's named generate_mbed_spm_partition_code.py instead of generate_spm_partition_code.py?

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 6, 2019

Author Contributor

Branding

@cmonr
Copy link
Contributor

left a comment

Typo needs fixing.

@cmonr

cmonr approved these changes Mar 6, 2019

Edit README.md
Edit file for minor grammar and style tweaks, mostly for consistent capitalization and tense across docs.
@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@AnotherButler thanks

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

CI started

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@NirSonnenschein If you want to take a look at this, or press the green button yourself 😁

@NirSonnenschein NirSonnenschein merged commit aedc1e1 into ARMmbed:master Mar 7, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10165 cycles (+968 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Thanks @cmonr merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.