Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA: Remove unused type which was conflicting wiith errno.h #9976

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@orenc17
Copy link
Contributor

commented Mar 7, 2019

Description

error_t was defined in MBED_SPM PSA implementation and was conflicting with error_t defined by the toolchains

as it is not being used in the PSA code at all, and not defined in PSA-FF spec we remove it.
The issue was found when compiling psoc6 with pelion-client

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa @TaniaMirzin

Release Notes

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

new tiny PR needed for cypress issue

@alzix

alzix approved these changes Mar 7, 2019

Copy link
Contributor

left a comment

LGTM

@0xc0170

0xc0170 approved these changes Mar 7, 2019

@0xc0170 0xc0170 requested a review from ChiefBureaucraticOfficer Mar 7, 2019

@0xc0170 0xc0170 added the needs: CI label Mar 7, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 7, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Mar 7, 2019

@ChiefBureaucraticOfficer
Copy link

left a comment

Meets criteria, PSA related. Approved.

@cmonr cmonr merged commit a00de86 into ARMmbed:master Mar 7, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9112 cycles (-1065 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 7, 2019

@orenc17 orenc17 deleted the kfnta:remove_error_t branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.