Nuget package dependencies incorrectly versioned producing build warnings in consumers

[DaveAurionix]

Apologies for the issue with no PR - mostly logging till have time to address it...

The Asos.SimpleEventStore.DocumentDb nuget package published by the build process contains a hard reference to a Asos.SimpleEventStore package with version 1.0.0 despite the actual build taking place against a later (non-backwards-compatible) package version (e.g. 2.X.X). This produces the following example warning in consumers using VS2017.3.4 or later:

"Asos.SimpleEventStore.AzureDocumentDb 2.0.31 depends on Asos.SimpleEventStore (>=1.0.0) but Asos.SimpleEventStore 1.0.0 was not found. An approximate best match of Asos.SimpleEventStore 2.0.30 was resolved".

This might stop "warnings as errors" being enabled for builds.

A temporary hack might be to simple change the Version property in the csproj files to match the version of any currently published package, but although that will remove the warning, I worry that this will simply mask the issue and might result in consumers who use "minimum matching package" dependency behaviour rarely picking up new dependent package versions (i.e. those that reference SES.DocDb will not update to latest versions of SES itself).

A better approach might be to use "$" build variables in the csproj files Version elements in order to create correctly-versioned references when msbuild is spidering project references to generate the package manifest.

[DaveAurionix]

Not sure this is fixed? If you expand the Dependencies on https://www.nuget.org/packages/Asos.SimpleEventStore.AzureDocumentDb/ it still shows a dependency on the hard-coded 1.0.0 version of Asos.SimpleEventStore, rather than the version actually required/referenced at build time.

[DaveAurionix]

The issue is when msbuild spiders the csproj dependencies (say B, C) of the csproj (A) that it is packaging. Those spidered dependencies have a 1.0.0 inside the B and C csproj files that is not affected by the /p:Version build parameter. That build parameter only affects the csproj currently being built (A in this example).

[asosMikeGore]

Yes it's not. Noticed an issue with the build script tweak I did that I've just pushed out too. Will look at this again shortly.

[asosMikeGore]

The issue is to do with the MSBuild version that is on our CI/CD server. Looking to get this updated. Even if you override the PackageVersion param as shown in the commit above, it still defaults to 1.0.0 on the build server.

[asosMikeGore]

This has just been fixed in package versions 2.0.58. It's indexing on nuget.org at the moment so you may not see it for a few mins.