Live app #95
Closed
Live app #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files of the live app
…wer.json file, and also added script for installing the live app in package.json
…files of the live app
…wer.json file, and also added script for installing the live app in package.json
…at-live-app-events
…-events branch of the live-app-asq repository
…wer.json file, and also added script for installing the live app in package.json
…files of the live app
…-events branch of the live-app-asq repository
…at-live-app-events
…s an Answer to an implicit question
…dent-question-events in cockpit-asq
…s an Answer to an implicit question
…, it will be treated as an upvote
… the data to the session (active question and questions made during said session), when the presenter changes slide it will close the modal if it is open
…e installing the live app bower components it removes the current one so we are sure that is up to date
…s between the html presentations and pdf presentations
…ce. Clicking it once will show the question clicking it twice it will close it. The presenter now knows which question is being broadcasted
triglian
commented
Mar 7, 2017
client/js/ghost.js
Outdated
| } | ||
| }) | ||
| eventBus.on('share-student-question', function (question) { | ||
| const app = document.getElementsByTagName('ASQ-LIVE-APP')[0]; |
There was a problem hiding this comment.
document.querySelector('asq-live-app')
client/js/ghost.js
Outdated
|
|
||
| eventBus.on('student-question-rated', function (evt) { | ||
| const app = document.getElementsByTagName('ASQ-LIVE-APP')[0]; | ||
| app.questionRated(evt.data.question); |
client/js/ghost.js
Outdated
|
|
||
| eventBus.on('update-student-questions', function (evt) { | ||
| const app = document.getElementsByTagName('ASQ-LIVE-APP')[0]; | ||
| if (evt && evt.data !== undefined) { |
client/js/viewer.js
Outdated
| } | ||
| }) | ||
| eventBus.on('share-student-question', function (question) { | ||
| const app = document.getElementsByTagName('ASQ-LIVE-APP')[0]; |
lib/liveApp/index.js
Outdated
| const _ = require('lodash'); | ||
| const socketEmitter = require('../socket/pubsub'); | ||
| const renameIdAndRemoveVersion = require('../utils/format').renameIdAndRemoveVersion; | ||
| const handleSliderChange = coroutine(function *handleSliderChangeGen (socket, evt) { |
There was a problem hiding this comment.
whitespace before function
lib/liveApp/index.js
Outdated
| questions: [implicitQuestion._id], | ||
| }; | ||
|
|
||
| const dummyExercise = yield Exercise |
There was a problem hiding this comment.
dummyExercise -> viewerQuestionsExercise
lib/socket/handlers.js
Outdated
| @@ -608,6 +608,53 @@ module.exports = function(socketUtils){ | |||
| pluginPubsub.emit('plugin', evt); | |||
| } | |||
|
|
|||
| const ctrlForwardDataToRoles = coroutine( function *ctrlForwardDataToRolesGen (evtName, data, sessionId) { | |||
There was a problem hiding this comment.
document function and if needed give a better name
| @@ -245,7 +246,12 @@ const startPresentation = coroutine(function *startPresentationGen(req, res, ne | |||
| .indexOf(req.body.flow) > -1 ) ? req.body.flow : 'ctrl'; | |||
| newSession.authLevel = ( Session.schema.path('authLevel').enumValues | |||
| .indexOf(req.body.authLevel) > -1 ) ? req.body.authLevel : 'public'; | |||
| newSession.data = { | |||
There was a problem hiding this comment.
put a comment above this
| }; | ||
|
|
||
| const implicitQuestion = new Question(implicitQuestionData); | ||
| const dummyExerciseData = { |
| const Promise = require('bluebird'); | ||
| const modulePath = '../../../lib/upload/liveApp'; | ||
|
|
||
| describe('liveApp.js',function(){ |
There was a problem hiding this comment.
we need moaaaarrrrrrrrrr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.