Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hj submit command #76

Merged
merged 7 commits into from
Oct 24, 2019
Merged

Hj submit command #76

merged 7 commits into from
Oct 24, 2019

Conversation

limhawjia
Copy link

closes #45

  • Created submit command
  • Created attempt command
  • Created exit command
  • Added extra functionality to model and logic classes

@limhawjia limhawjia force-pushed the hj-submit-command branch 2 times, most recently from 65146b6 to b3d02ee Compare October 24, 2019 13:17
zhangj1an
zhangj1an previously approved these changes Oct 24, 2019
View reviewed changes
Copy link

@zhangj1an zhangj1an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ning-sy210
ning-sy210 previously approved these changes Oct 24, 2019
View reviewed changes
Copy link

@ning-sy210 ning-sy210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@limhawjia limhawjia dismissed stale reviews from ning-sy210 and zhangj1an via c32317a October 24, 2019 14:29
alxkohh
alxkohh approved these changes Oct 24, 2019
View reviewed changes
Copy link

@alxkohh alxkohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ning-sy210
ning-sy210 approved these changes Oct 24, 2019
View reviewed changes
Copy link

@ning-sy210 ning-sy210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ning-sy210 ning-sy210 merged commit 1b3b465 into master Oct 24, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 25, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxkohh alxkohh alxkohh approved these changes

@ning-sy210 ning-sy210 ning-sy210 approved these changes

@zhangj1an zhangj1an zhangj1an left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submit command
4 participants
@limhawjia @zhangj1an @alxkohh @ning-sy210